fix: Fix vertexing for physmon ckf tracking #2547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Infrastructure
Codecov Report
@@ Coverage Diff @@
## main #2547 +/- ##
=======================================
Coverage 49.76% 49.76%
=======================================
Files 466 466
Lines 26326 26326
Branches 12097 12097
=======================================
Hits 13101 13101
Misses 4624 4624
Partials 8601 8601 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
felix-russo
reviewed
Oct 17, 2023
that refers to the seeder not the track finding |
felix-russo
previously approved these changes
Oct 17, 2023
acts-policybot
bot
dismissed
felix-russo’s stale review
Invalidated by push of 3f4f80a
paulgessinger
approved these changes
Oct 17, 2023
acts-project-service
added
the
Fails Athena tests
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 25, 2023
Currently our Fatras simulation does not remember the surface particles were created on. This is a problem for the navigation as we cannot know if a close by surface was already encountered or not. I propose to add a reference surface to the Fatras `Particle` which can be carried through in the propagation and then be used as a starting point for a new propagation. We will also have to decide if a photon conversion on a sensitive surface should result in a hit or not. But this should be done in a separate PR if possible. blocked by - #2547 - #2549
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
associatedParticlesshould not be used after CKF as we cannot guarantee that they will line up with tracks coming from the CKF. this way the writer will try to associate the particles via tracks itself.