-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: DiscTrapezoidBounds vertices #2541
Merged
kodiakhq
merged 3 commits into
acts-project:main
from
XiaocongAi:fix-discTrapezoid-vertices
Oct 13, 2023
Merged
fix: DiscTrapezoidBounds vertices #2541
kodiakhq
merged 3 commits into
acts-project:main
from
XiaocongAi:fix-discTrapezoid-vertices
Oct 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @asalzburger , could you help have a look? |
Codecov Report
@@ Coverage Diff @@
## main #2541 +/- ##
=======================================
Coverage 49.77% 49.77%
=======================================
Files 466 466
Lines 26311 26314 +3
Branches 12093 12093
=======================================
+ Hits 13096 13099 +3
Misses 4616 4616
Partials 8599 8599
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
paulgessinger
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the vertices calculation of a trapezoid in the local frame (before the transformation).