Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DiscTrapezoidBounds vertices #2541

Merged
merged 3 commits into from
Oct 13, 2023

Conversation

XiaocongAi
Copy link
Contributor

This PR fixes the vertices calculation of a trapezoid in the local frame (before the transformation).

@github-actions github-actions bot added the Component - Core Affects the Core module label Oct 12, 2023
@XiaocongAi
Copy link
Contributor Author

Hi @asalzburger , could you help have a look?

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #2541 (4b91c83) into main (16e44c0) will increase coverage by 0.00%.
The diff coverage is 42.85%.

@@           Coverage Diff           @@
##             main    #2541   +/-   ##
=======================================
  Coverage   49.77%   49.77%           
=======================================
  Files         466      466           
  Lines       26311    26314    +3     
  Branches    12093    12093           
=======================================
+ Hits        13096    13099    +3     
  Misses       4616     4616           
  Partials     8599     8599           
Files Coverage Δ
Core/src/Surfaces/DiscTrapezoidBounds.cpp 74.50% <42.85%> (+1.59%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@paulgessinger paulgessinger added this to the next milestone Oct 12, 2023
@kodiakhq kodiakhq bot merged commit 43411f1 into acts-project:main Oct 13, 2023
@paulgessinger paulgessinger modified the milestones: next, v30.3.0 Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants