feat: MaterialComposition plots with python config #2531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think we actually need that at all.
Codecov Report
@@ Coverage Diff @@
## main #2531 +/- ##
=======================================
Coverage 49.77% 49.77%
=======================================
Files 466 466
Lines 26311 26311
Branches 12093 12093
=======================================
Hits 13096 13096
Misses 4616 4616
Partials 8599 8599 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
andiwand
approved these changes
Oct 12, 2023
acts-project-service
added
the
Fails Athena tests
paulgessinger
added a commit
that referenced
this pull request
Oct 13, 2023
Changes the material composition script to optionally accept a region config in the form of a JSON config file like
```json
{
"beampipe": [
{
"rmin": 0,
"rmax": 24.4,
"zmin": -4000,
"zmax": 4000
}
],
"pixel": [
{
"rmin": 25,
"rmax": 200,
"zmin": -2400,
"zmax": 2400
}
],
"sstrips": [
{
"rmin": 202,
"rmax": 720,
"zmin": -3150,
"zmax": 3150
}
],
"lstrips": [
{
"rmin": 720,
"rmax": 1140,
"zmin": -3150,
"zmax": 3150
}
],
"solenoid": [
{
"rmin": 1160,
"rmax": 1200,
"zmin": -3000,
"zmax": 3000
}
],
"ecalbarrel": [
{
"rmin": 1250,
"rmax": 1500,
"zmin": -3050,
"zmax": 3050
}
],
"ecalendcap": [
{
"rmin": 315,
"rmax": 1500,
"zmin": 3200,
"zmax": 3450
},
{
"rmin": 315,
"rmax": 1500,
"zmin": -3450,
"zmax": -3200
}
]
}
```
for the example of the ODD. This then also allows to have multiple $rz$ regions make up a combined grouping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the material composition script to optionally accept a region config in the form of a JSON config file like
{ "beampipe": [ { "rmin": 0, "rmax": 24.4, "zmin": -4000, "zmax": 4000 } ], "pixel": [ { "rmin": 25, "rmax": 200, "zmin": -2400, "zmax": 2400 } ], "sstrips": [ { "rmin": 202, "rmax": 720, "zmin": -3150, "zmax": 3150 } ], "lstrips": [ { "rmin": 720, "rmax": 1140, "zmin": -3150, "zmax": 3150 } ], "solenoid": [ { "rmin": 1160, "rmax": 1200, "zmin": -3000, "zmax": 3000 } ], "ecalbarrel": [ { "rmin": 1250, "rmax": 1500, "zmin": -3050, "zmax": 3050 } ], "ecalendcap": [ { "rmin": 315, "rmax": 1500, "zmin": 3200, "zmax": 3450 }, { "rmin": 315, "rmax": 1500, "zmin": -3450, "zmax": -3200 } ] }for the example of the ODD. This then also allows to have multiple$rz$ regions make up a combined grouping.