-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change stalebot days until close time #253
Conversation
I think I misunderstood how this number is interpreted. I set it to 60, but that means 60 days after the issue is marked stale it will be deleted. This PR changes that number down to 14, which means after 30+14 = 44 days an issue without any activity other than this bot will be closed.
14 days might be a tight strict. 30+30 maybe? Could we also ensure that long-term issues are never marked stale? |
I think 14 is good. You get a notification after 30 days because the label is added, so theres plenty of time to simply remove the label, that counts as activity. I think it's even better to have it short, otherwise you might "forget" to have activity. |
Also, technically there is a way, but I think we shouldn't exclude any issues from this. This is a nice way to force you to reevaluate even long term issues every 30 days. That's a good thing, and simply removing the stale label is fine. |
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
=======================================
Coverage 44.86% 44.86%
=======================================
Files 376 376
Lines 18868 18868
Branches 8970 8970
=======================================
Hits 8465 8465
Misses 4904 4904
Partials 5499 5499 Continue to review full report at Codecov.
|
Fair enough. Will merge it as-is then. |
I think I misunderstood how this number is interpreted. I set it to 60, but that means 60 days after the issue is marked stale it will be deleted. This PR changes that number down to 14, which means after 30+14 = 44 days an issue without any activity other than this bot will be closed.
I think I misunderstood how this number is interpreted. I set it to 60,
but that means 60 days after the issue is marked stale it will be
deleted. This PR changes that number down to 14, which means after 30+14
= 44 days an issue without any activity other than this bot will be
closed.