Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change stalebot days until close time #253

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

paulgessinger
Copy link
Member

I think I misunderstood how this number is interpreted. I set it to 60,
but that means 60 days after the issue is marked stale it will be
deleted. This PR changes that number down to 14, which means after 30+14
= 44 days an issue without any activity other than this bot will be
closed.

I think I misunderstood how this number is interpreted. I set it to 60,
but that means 60 days after the issue is marked stale it will be
deleted. This PR changes that number down to 14, which means after 30+14
= 44 days an issue without any activity other than this bot will be
closed.
@paulgessinger paulgessinger added the Infrastructure Changes to build tools, continous integration, ... label Jun 12, 2020
@acts-issue-bot acts-issue-bot bot removed the Triage label Jun 12, 2020
@paulgessinger paulgessinger added this to the v0.26.00 milestone Jun 12, 2020
@msmk0 msmk0 added the Improvement Changes to an existing feature label Jun 12, 2020
@msmk0
Copy link
Contributor

msmk0 commented Jun 12, 2020

14 days might be a tight strict. 30+30 maybe?

Could we also ensure that long-term issues are never marked stale?

@paulgessinger
Copy link
Member Author

I think 14 is good. You get a notification after 30 days because the label is added, so theres plenty of time to simply remove the label, that counts as activity. I think it's even better to have it short, otherwise you might "forget" to have activity.

@paulgessinger
Copy link
Member Author

Also, technically there is a way, but I think we shouldn't exclude any issues from this. This is a nice way to force you to reevaluate even long term issues every 30 days. That's a good thing, and simply removing the stale label is fine.

@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #253 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #253   +/-   ##
=======================================
  Coverage   44.86%   44.86%           
=======================================
  Files         376      376           
  Lines       18868    18868           
  Branches     8970     8970           
=======================================
  Hits         8465     8465           
  Misses       4904     4904           
  Partials     5499     5499           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6220f45...08a91bc. Read the comment docs.

@msmk0
Copy link
Contributor

msmk0 commented Jun 12, 2020

Fair enough. Will merge it as-is then.

@msmk0 msmk0 merged commit a2df1c9 into acts-project:master Jun 12, 2020
@paulgessinger paulgessinger deleted the stale_bot branch June 12, 2020 09:47
paulgessinger added a commit to paulgessinger/acts that referenced this pull request Jul 13, 2020
I think I misunderstood how this number is interpreted. I set it to 60,
but that means 60 days after the issue is marked stale it will be
deleted. This PR changes that number down to 14, which means after 30+14
= 44 days an issue without any activity other than this bot will be
closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Changes to an existing feature Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants