fix: Update RootTrajectorySummaryWriter.cpp - writing the correct vector to branch (outlierChi2) #2488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: once we're done, I will merge this one manually so @altsybee shows up in the merge commit correctly. |
# Conflicts: # CI/physmon/reference/performance_ckf_seeded.root # CI/physmon/reference/performance_ckf_truth_smeared.root # Examples/Python/tests/root_file_hashes.txt
github-actions
bot
added
Infrastructure
Codecov Report
@@ Coverage Diff @@
## main #2488 +/- ##
=======================================
Coverage 49.77% 49.77%
=======================================
Files 466 466
Lines 26310 26310
Branches 12093 12093
=======================================
Hits 13095 13095
Misses 4616 4616
Partials 8599 8599 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
# Conflicts: # CI/physmon/reference/tracksummary_ckf_orthogonal_hist.root # CI/physmon/reference/tracksummary_ckf_seeded_hist.root # CI/physmon/reference/tracksummary_ckf_truth_estimated_hist.root # CI/physmon/reference/tracksummary_ckf_truth_smeared_hist.root # Examples/Python/tests/root_file_hashes.txt
github-actions
bot
removed
Infrastructure
github-actions
bot
added
Infrastructure
|
Merged this one manually so @altsybee is mentioned. |
acts-project-service
added
the
Fails Athena tests
|
Failure is the metadata failure. |
paulgessinger
removed
the
Fails Athena tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: writing the correct vector to branch: outlierChi2 instead of measurementChi2.
Reopened #2363 so I can update the references.