Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix units in RootParticleReader #2477

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

andiwand
Copy link
Contributor

Effectively only time was broken but I made the other units also explicit.

@andiwand andiwand added this to the next milestone Sep 22, 2023
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Sep 22, 2023
Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #2477 (d61c6d4) into main (f6d9c0a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2477   +/-   ##
=======================================
  Coverage   49.81%   49.81%           
=======================================
  Files         466      466           
  Lines       26190    26190           
  Branches    12009    12009           
=======================================
  Hits        13047    13047           
  Misses       4620     4620           
  Partials     8523     8523           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit 7f8d143 into acts-project:main Sep 22, 2023
@andiwand andiwand deleted the fix-rootparticlereader-units branch September 22, 2023 18:54
@paulgessinger paulgessinger modified the milestones: next, v30.0.0 Sep 25, 2023
AJPfleger pushed a commit to AJPfleger/acts that referenced this pull request Sep 29, 2023
Effectively only time was broken but I made the other units also explicit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants