-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix units in RootParticleReader
#2477
Merged
kodiakhq
merged 1 commit into
acts-project:main
from
andiwand:fix-rootparticlereader-units
Sep 22, 2023
Merged
fix: Fix units in RootParticleReader
#2477
kodiakhq
merged 1 commit into
acts-project:main
from
andiwand:fix-rootparticlereader-units
Sep 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminhuth
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
Codecov Report
@@ Coverage Diff @@
## main #2477 +/- ##
=======================================
Coverage 49.81% 49.81%
=======================================
Files 466 466
Lines 26190 26190
Branches 12009 12009
=======================================
Hits 13047 13047
Misses 4620 4620
Partials 8523 8523 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AJPfleger
pushed a commit
to AJPfleger/acts
that referenced
this pull request
Sep 29, 2023
Effectively only time was broken but I made the other units also explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effectively only time was broken but I made the other units also explicit.