fix: Fix Kalman filter extrapolation after smoothing

[andiwand]

KF and CKF are extrapolating from the last track state to the perigee. This can decrease the resolution drastically if that last state is a material state or hole (state without measurement).

Here I exclude these states and propagate from the last measurement to the perigee.

old

new

[paulgessinger]

So by this you mean from the innermost measurement state to the perigee, right?

[benjaminhuth]

I think it would be great if you could add a comment explaining what is done here and why

[codecov]

Codecov Report

Merging #2470 (e23bcac) into main (45e07d7) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2470   +/-   ##
=======================================
  Coverage   49.88%   49.88%           
=======================================
  Files         466      466           
  Lines       26232    26232           
  Branches    12014    12014           
=======================================
  Hits        13086    13086           
  Misses       4614     4614           
  Partials     8532     8532           

Files Changed	Coverage Δ
...de/Acts/TrackFinding/CombinatorialKalmanFilter.hpp	31.63% <0.00%> (ø)
Core/include/Acts/TrackFitting/KalmanFitter.hpp	42.41% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

📊: Physics performance monitoring for e23bcac

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles inital fatras
• ✅ Particles final fatras
• ✅ Particles inital geant4
• ✅ Particles final geant4

[andiwand]

opinions on the performance changes @paulgessinger @asalzburger @benjaminhuth ?

[asalzburger]

opinions on the performance changes @paulgessinger @asalzburger @benjaminhuth ?

I am looking through it ...

[paulgessinger]

Seems fine to me. Let's do the thing.

[andiwand]

waiting for #2336 to go in then I will update the references here

[acts-project-service]

✅ Athena integration test results

✅ All tests successful

status	job
🟢	run_unit_tests
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data