feat: make material interaction volume agnostic #2455
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Corentin-Allaire - as discussed, this is the first PR for the interaction recording, probably we can use the same strategy for the mapping. Would you agree to review this? |
github-actions
bot
added
Component - Core
|
Some problem with rebasing, closing and updating .. it |
asalzburger
deleted the
feat-make-material-interaction-volume-agnostic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the (recording of) material interaction work with
Acts::TrackingVolumeandActs::DetectorVolumeby introducing a small helper switch class between the two.If this concept is successful, this can be used also for the
MaterialMappingto let the two geometries coexist and co-use the same tooling chain.