refactor: Reduce number of surface allocations in vertexing

[paulgessinger]

No description provided.

[paulgessinger]

The billoir fitter actually updates the linearization point each iteration. So moved the surface creation into that loop, but it's still outside of the loop over all tracks, so at least we don't create a surface for each track and each iteration.

[codecov]

Codecov Report

Merging #2443 (2035860) into main (ac8ec6e) will decrease coverage by 0.05%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##             main    #2443      +/-   ##
==========================================
- Coverage   49.90%   49.86%   -0.05%     
==========================================
  Files         466      466              
  Lines       26231    26249      +18     
  Branches    12013    12032      +19     
==========================================
- Hits        13090    13088       -2     
- Misses       4613     4614       +1     
- Partials     8528     8547      +19     

Files Changed	Coverage Δ
.../include/Acts/Vertexing/HelicalTrackLinearizer.hpp	100.00% <ø> (ø)
.../include/Acts/Vertexing/HelicalTrackLinearizer.ipp	25.55% <0.00%> (-1.42%)	⬇️
...e/include/Acts/Vertexing/IterativeVertexFinder.hpp	80.00% <ø> (ø)
...nclude/Acts/Vertexing/NumericalTrackLinearizer.hpp	90.00% <ø> (ø)
...nclude/Acts/Vertexing/NumericalTrackLinearizer.ipp	11.47% <0.00%> (-3.28%)	⬇️
...e/include/Acts/Vertexing/IterativeVertexFinder.ipp	25.57% <25.00%> (-1.13%)	⬇️
...clude/Acts/Vertexing/AdaptiveMultiVertexFitter.ipp	43.87% <40.00%> (-0.87%)	⬇️
...include/Acts/Vertexing/FullBilloirVertexFitter.ipp	28.47% <50.00%> (+0.10%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

📊: Physics performance monitoring for 2035860

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles inital fatras
• ✅ Particles final fatras
• ✅ Particles inital geant4
• ✅ Particles final geant4

[felix-russo]

Nice! Just one comment:

[acts-project-service]

✅ Athena integration test results

✅ All tests successful

status	job
🟢	run_unit_tests
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data