refactor: Align overstep limit

[andiwand]

Overstep limits are defined differently in our 3 steppers. This PR aligns them to the convention in the EigenStepper. The StraightLineStepper returned the wrong sign which might have affected Fatras simulation for neutral particles.

Pulled out of #2336

[codecov]

Codecov Report

Merging #2441 (4a7fa73) into main (e8600a4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2441   +/-   ##
=======================================
  Coverage   49.71%   49.71%           
=======================================
  Files         461      461           
  Lines       25986    25988    +2     
  Branches    11935    11935           
=======================================
+ Hits        12918    12920    +2     
  Misses       4600     4600           
  Partials     8468     8468           

Files Changed	Coverage Δ
Core/include/Acts/Propagator/AtlasStepper.hpp	72.22% <100.00%> (+0.03%)	⬆️
...re/include/Acts/Propagator/StraightLineStepper.hpp	73.91% <100.00%> (+0.38%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

📊: Physics performance monitoring for 4a7fa73

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles inital fatras
• ✅ Particles final fatras
• ✅ Particles inital geant4
• ✅ Particles final geant4

[andiwand]

I looked at the tracksummary and it seems like we reconstruct 4 additional tracks which have some holes and bad pT estimate. I do not think existing performance is impacted but I could double check if necessary

Opinion @paulgessinger @benjaminhuth ?

[benjaminhuth]

I looked at the tracksummary and it seems like we reconstruct 4 additional tracks which have some holes and bad pT estimate. I do not think existing performance is impacted but I could double check if necessary

This means, the fitted params in the tracksummary of particles that were reconstructed before don't change significantly, right?
So we can trace the changes back to diff in simulation, that allows more particles to pass the truth seeding cuts or so?

[andiwand]

This means, the fitted params in the tracksummary of particles that were reconstructed before don't change significantly, right? So we can trace the changes back to diff in simulation, that allows more particles to pass the truth seeding cuts or so?

This or it was a fit with errors before.

I guess I could also try to diff the particles/hits to see if my hypothesis holds. But I guess a bunch of them also have some slight numerical differences

[paulgessinger]

The ttbar job is pretty low-stats in any case, so not sure how much we need to read into fluctuations there.

[acts-project-service]

✅ Athena integration test results

✅ All tests successful

status	job
🟢	run_unit_tests
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data