Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Disable autodiff plugin for lcg #2433

Merged
merged 4 commits into from
Sep 11, 2023

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Sep 8, 2023

Autodiff is causing troubles from time to time while refactoring code. There is another occurrence in #2341 and it seems easiest to not use that plugin on that platform in the CI. The plugin is still tested on ubuntu for example where it works without troubles.

Pulled out of #2341

@andiwand andiwand added this to the next milestone Sep 8, 2023
@github-actions github-actions bot added the Infrastructure Changes to build tools, continous integration, ... label Sep 8, 2023
@andiwand
Copy link
Contributor Author

andiwand commented Sep 8, 2023

discussed with @benjaminhuth

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #2433 (620bb34) into main (109fb7d) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head 620bb34 differs from pull request most recent head 0cbbd5c. Consider uploading reports for the commit 0cbbd5c to get more accurate results

@@           Coverage Diff           @@
##             main    #2433   +/-   ##
=======================================
  Coverage   49.70%   49.70%           
=======================================
  Files         455      455           
  Lines       25840    25840           
  Branches    11861    11861           
=======================================
  Hits        12843    12843           
  Misses       4592     4592           
  Partials     8405     8405           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@paulgessinger paulgessinger changed the title ci: Diable autodiff plugin for lcg ci: Disable autodiff plugin for lcg Sep 11, 2023
@kodiakhq kodiakhq bot merged commit b10f804 into acts-project:main Sep 11, 2023
@andiwand andiwand deleted the disable-autodiff-for-lcg branch September 11, 2023 12:33
@paulgessinger paulgessinger modified the milestones: next, v29.2.0 Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants