Consistent track parameters names (Part 1) #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msmk0
added
Component - Core
msmk0
force-pushed
the
151-consistent-track-parameters-names-part1
branch
4 times, most recently
from
78b60b8 to
9093c72
Compare
|
The coverage debug build is failling for unknown reasons and there are no logs or error messages. Does anyone have an idea? Could this be the disk space issue again? |
msmk0
force-pushed
the
151-consistent-track-parameters-names-part1
branch
from
9093c72 to
2730f9c
Compare
Codecov Report
@@ Coverage Diff @@
## master #241 +/- ##
==========================================
- Coverage 48.41% 48.37% -0.05%
==========================================
Files 319 320 +1
Lines 16336 16381 +45
Branches 7570 7587 +17
==========================================
+ Hits 7909 7924 +15
- Misses 3175 3189 +14
- Partials 5252 5268 +16
Continue to review full report at Codecov.
|
msmk0
force-pushed
the
151-consistent-track-parameters-names-part1
branch
from
2730f9c to
46a8bc7
Compare
|
@Corentin-Allaire I fixed the typo and hopefully answered the outstanding questions. |
|
That is all good for me. Do we want to let Fabian have a look at it ? |
Corentin-Allaire
approved these changes
Jun 18, 2020
I'm reading it atm |
FabianKlimpel
approved these changes
Jun 18, 2020
msmk0
force-pushed
the
151-consistent-track-parameters-names-part1
branch
from
c6079e1 to
a764e07
Compare
msmk0
force-pushed
the
151-consistent-track-parameters-names-part1
branch
from
a764e07 to
a5b74f6
Compare
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Jul 13, 2020
* EventData: rename free track parameters * EventData: remove unqualified track parameters typedef * EventData: rename neutral parameters header * EventData: rename charge parameters implementation file * EventData: remove unneeded cstors/dstore from free params * EventData: fix explicit template instantiations * EventData: rename neutral typedefs * EventData: remove unnecessary include * EventData: rename charged free params typedef * Examples: fix track parameters type * Tests: rename track param tests * Tests: fix track parameters type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename track parameter classes as decided in #151.
This renames the
Single...TrackParametersbase classes, the neutral typedefs, and the charge free parameters typedef. The{Bound,Curvilinear}Parametersare left for a second PR to reduce this PRs size.