Untemplate methods in TrackingVolume #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were only templated for convenience, but don't need to be. Also moves one method that is only needed in the implementation to an anonymous namespace in said implementation file.
|
I didn't push to my fork by accident. Damn. |
HadrienG2
approved these changes
Jun 11, 2020
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
==========================================
- Coverage 44.96% 44.94% -0.02%
==========================================
Files 374 374
Lines 18709 18708 -1
Branches 8854 8859 +5
==========================================
- Hits 8413 8409 -4
Misses 4906 4906
- Partials 5390 5393 +3
Continue to review full report at Codecov.
|
msmk0
added
Component - Core
paulgessinger
added a commit
to paulgessinger/acts
that referenced
this pull request
Jul 13, 2020
They were only templated for convenience, but don't need to be. Also moves one method that is only needed in the implementation to an anonymous namespace in said implementation file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were only templated for convenience, but don't need to be.
Also moves one method that is only needed in the implementation to an anonymous
namespace in said implementation file.