Replace auto keywords in KalmanVertexUpdaters by explicit types #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baschlag
added
Component - Core
|
Hi @baschlag - yes, I think this is the lazy evaluation of Eigen, I tend to use auto for retrieval types, but not very much anymore for Eigen. |
asalzburger
approved these changes
Jun 8, 2020
Thanks! I found one more case where I'm doing this. I will quickly add it to this PR. |
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
==========================================
- Coverage 44.99% 44.96% -0.03%
==========================================
Files 374 374
Lines 18697 18709 +12
Branches 8842 8854 +12
==========================================
Hits 8413 8413
Misses 4906 4906
- Partials 5378 5390 +12
Continue to review full report at Codecov.
|
|
Coverage check seems to be stuck. Seems fine though. Merging. |
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Jul 13, 2020
…-project#235) * remove auto keywords in KalmanVertex*Updaters and replace with explicit types * replace auto keywords with explicit types in AMVFinder and AMVFitter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all unnecessary
autokeywords in theKalmanVertexUpdaterandKalmanVertexTrackUpdaterand replaces them with the explicit types instead. Some recent, already fixed (and extremely hard to find) bugs appeared only in release (and not debug) build mode due to weird behaviour in the combined usage ofautoand Eigens.block<>operations (in a different place).//Edit: AMVFitter and AMVFinder have also been updated.