Add track EDM visualization #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiaocongAi
added
🚧 WIP
Codecov Report
@@ Coverage Diff @@
## master #233 +/- ##
=======================================
Coverage 44.86% 44.87%
=======================================
Files 376 376
Lines 18868 18901 +33
Branches 8970 8990 +20
=======================================
+ Hits 8465 8481 +16
Misses 4904 4904
- Partials 5499 5516 +17
Continue to review full report at Codecov.
|
|
The zoomed plots:
|
asalzburger
approved these changes
Jun 11, 2020
|
I override the patch, since the overall has no change. |
|
To avoid these overlaps seen on the last picture, one could stack the out of plane prescriptions, right? |
|
@asalzburger , right. We could use different out of plane factors for them. Let me change this. |
|
@asalzburger , the plot looks much better now. 😃 |
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Jul 13, 2020
* Add function to draw trajectory * Fix the comments * Add parameter to shift from plane * Add test to construct a track and draw it * Fix the test surface construction * Fix the comment * Use different outOfPlane values for different parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the visualization for a track to show optionally the surface (yellow color), calibrated measurement (orange color), predicted (light blue color)/filtered (dark blue color)/smoothed (green color) track parameters at each track state.
To get a realistic fitted track, the test first construct a detector with six plane surfaces, then create measurements and construct KalmanFitter to perform the fit, and finally draw the fitted track as below:
