Fix bound parameters visualization #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiaocongAi
added
Bug
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
==========================================
- Coverage 45.00% 44.99% -0.01%
==========================================
Files 374 374
Lines 18697 18697
Branches 8841 8842 +1
==========================================
- Hits 8414 8413 -1
Misses 4906 4906
- Partials 5377 5378 +1
Continue to review full report at Codecov.
|
asalzburger
approved these changes
Jun 3, 2020
|
Overwriting pathetic 0.01 % codcov patch complaint. |
FabianKlimpel
pushed a commit
to FabianKlimpel/acts
that referenced
this pull request
Jun 3, 2020
FabianKlimpel
pushed a commit
to FabianKlimpel/acts
that referenced
this pull request
Jun 3, 2020
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a simple fix to the
drawBoundParametersfunction.Before this fix, the ellipse showing covariance of local position is displaced from the cone showing the covariance of momentum direction as below:
After the fix, they origin of the cone overlaps with the center of the ellipse as expected: