Make the condition of equal operator of spacepoint tighter #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #225 +/- ##
=======================================
Coverage 45.00% 45.00%
=======================================
Files 374 374
Lines 18697 18697
Branches 8841 8841
=======================================
Hits 8414 8414
Misses 4906 4906
Partials 5377 5377 Continue to review full report at Codecov.
|
HadrienG2
approved these changes
May 28, 2020
FabianKlimpel
pushed a commit
to FabianKlimpel/acts
that referenced
this pull request
May 29, 2020
…ect#225) * Make the condition of equal operator tighter * clang tidy
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Jul 13, 2020
…ect#225) * Make the condition of equal operator tighter * clang tidy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the equal operator condition should include variance information as well