Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use template for source link container in CKF #210

Merged
merged 3 commits into from
May 20, 2020
Merged

Use template for source link container in CKF #210

merged 3 commits into from
May 20, 2020

Conversation

XiaocongAi
Copy link
Contributor

This PR makes the CKF templated on the source link container (instead of using std::vector).
This could avoid redundant container conversion from boost::flat_multiset to std::vector.

@XiaocongAi XiaocongAi added Component - Core Affects the Core module Component - Examples Affects the Examples module Impact - Minor Nuissance bug and/or affects only a single module Improvement Changes to an existing feature labels May 20, 2020
@acts-issue-bot acts-issue-bot bot removed the Triage label May 20, 2020
@codecov
Copy link

codecov bot commented May 20, 2020 •
edited
Loading

Codecov Report

Merging #210 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #210   +/-   ##
=======================================
  Coverage   44.87%   44.87%           
=======================================
  Files         372      372           
  Lines       18653    18653           
  Branches     8824     8824           
=======================================
  Hits         8370     8370           
  Misses       4915     4915           
  Partials     5368     5368
Impacted Files Coverage Δ
...ude/Acts/TrackFinder/CombinatorialKalmanFilter.hpp 28.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82944dd...f01fd32. Read the comment docs.

msmk0
msmk0 approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@msmk0 msmk0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good. Thanks for the quick follow up.

@asalzburger
Copy link
Contributor

@XiaocongAi - please rebase this one & I will merge then.

@msmk0 msmk0 merged commit 7dce656 into acts-project:master May 20, 2020
@paulgessinger paulgessinger added this to the v0.25.00 milestone May 20, 2020
paulgessinger pushed a commit to paulgessinger/acts that referenced this pull request Jul 13, 2020
@XiaocongAi @paulgessinger
Use template for source link container in CKF (acts-project#210)
b508a20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msmk0 msmk0 msmk0 approved these changes

Assignees
No one assigned
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Impact - Minor Nuissance bug and/or affects only a single module Improvement Changes to an existing feature
Projects
None yet
Milestone
v0.25.00
Development

Successfully merging this pull request may close these issues.
4 participants
@XiaocongAi @asalzburger @msmk0 @paulgessinger