refactor: navigator volume material handling #2047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2047 +/- ##
=======================================
Coverage 49.83% 49.83%
=======================================
Files 420 420
Lines 23959 23962 +3
Branches 10858 10859 +1
=======================================
+ Hits 11940 11942 +2
- Misses 4389 4390 +1
Partials 7630 7630
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 8b806e9Full report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Apr 25, 2023
split off changes from my [calorimeter demo](https://github.com/acts-project/acts/compare/main...andiwand:tmp-calorimeter-demo?expand=1). this adds a shortcut for getting the current volume material from the navigator. since the new geometry has a different volume class we cannot reach the material in a generic way out of the box
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
split off changes from my calorimeter demo. this adds a shortcut for getting the current volume material from the navigator. since the new geometry has a different volume class we cannot reach the material in a generic way out of the box