Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix skipped Geant4 tests, always enable all tests by default in CI #2032

Merged
merged 6 commits into from
Apr 17, 2023

Conversation

paulgessinger
Copy link
Member

I'm manually skipping the exatrkx test in the default CI run via -k now.

@paulgessinger paulgessinger added this to the next milestone Apr 14, 2023
@github-actions
Copy link

github-actions bot commented Apr 14, 2023

📊 Physics performance monitoring for eb6688f

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@paulgessinger
Copy link
Member Author

There are some hash mismatches:

test_geant4__particles_final.root: ba00c21e6f0696316000f5ff7f0fb27df72d191157043bfa815844d8897056b7
test_geant4__particles_initial.root: 9eea306cd4ece5f509d73c0cc8de1bd321b2b40646bfcd5cc148a7ccf77980d8
test_geant4__hits.root: 6ab07fe4fe596c6948d7c4b821e51f6fae4ba69ac5cc62c07798c7de1cedfccb

I guess we didn't catch those when I bumped the G4 version because the jobs stopped being run. I'm probably going to just update them.

/cc @andiwand

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #2032 (12edc4f) into main (a1b43a8) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 12edc4f differs from pull request most recent head eb6688f. Consider uploading reports for the commit eb6688f to get more accurate results

@@            Coverage Diff             @@
##             main    #2032      +/-   ##
==========================================
- Coverage   49.86%   49.83%   -0.03%     
==========================================
  Files         421      421              
  Lines       23886    23899      +13     
  Branches    10841    10842       +1     
==========================================
  Hits        11911    11911              
- Misses       4354     4367      +13     
  Partials     7621     7621              

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit a511218 into acts-project:main Apr 17, 2023
@paulgessinger paulgessinger modified the milestones: next, v25.0.0 Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants