refactor: and fix new detector geometry #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andiwand
commented
Apr 12, 2023
andiwand
commented
- detector volumes now also have a volume finder delegate
- detector volume inside method will not check against its subvolumes
- detector will not add subvolumes of its volumes to its list
andiwand
added
Component - Core
Codecov Report
@@ Coverage Diff @@
## main #2027 +/- ##
==========================================
- Coverage 49.87% 49.82% -0.06%
==========================================
Files 421 420 -1
Lines 23898 23955 +57
Branches 10843 10857 +14
==========================================
+ Hits 11920 11935 +15
- Misses 4357 4388 +31
- Partials 7621 7632 +11
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
andiwand
force-pushed
the
refactor-and-fix-new-detector-geometry
branch
from
ec1b1c4 to
2fd8882
Compare
📊 Physics performance monitoring for a5f0697Full report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
instead of templates
asalzburger
approved these changes
Apr 18, 2023
andiwand
commented
Apr 18, 2023
|
handled your comments @asalzburger - thanks! |
asalzburger
approved these changes
Apr 20, 2023
asalzburger
added a commit
that referenced
this pull request
Apr 20, 2023
with #2027 I removed the ability to have multiple root volumes. this functionality is brought back in this PR because it is necessary for the KDT detector builder --------- Co-authored-by: Andreas Salzburger <[email protected]>
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Apr 25, 2023
- detector volumes now also have a volume finder delegate - detector volume inside method will not check against its subvolumes - detector will not add subvolumes of its volumes to its list
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Apr 25, 2023
with acts-project#2027 I removed the ability to have multiple root volumes. this functionality is brought back in this PR because it is necessary for the KDT detector builder --------- Co-authored-by: Andreas Salzburger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.