feat: Mockup builder class with a cpp script for test #2008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2008 +/- ##
=======================================
Coverage 49.82% 49.82%
=======================================
Files 421 421
Lines 23878 23878
Branches 10835 10835
=======================================
Hits 11898 11898
Misses 4366 4366
Partials 7614 7614 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
noemina
reviewed
Apr 3, 2023
andiwand
reviewed
Apr 3, 2023
Examples/Detectors/Geant4Detector/include/ActsExamples/Geant4Detector/MockupSectorBuilder.hpp
Outdated
Show resolved
Hide resolved
Examples/Detectors/Geant4Detector/include/ActsExamples/Geant4Detector/MockupSectorBuilder.hpp
Outdated
Show resolved
Hide resolved
Examples/Detectors/Geant4Detector/include/ActsExamples/Geant4Detector/MockupSectorBuilder.hpp
Outdated
Show resolved
Hide resolved
andiwand
added
Component - Examples
|
two more general comments
|
noemina
reviewed
Apr 5, 2023
|
@dimitra97, the configuration of the build fails because the your package requires actsvg. |
📊 Physics performance monitoring for ae91d76Full report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
This reverts commit 7f7cfc0.
Co-authored-by: Noemi Calace <[email protected]>
…etector/MockupSectorBuilder.hpp Co-authored-by: Andreas Stefl <[email protected]>
…etector/MockupSectorBuilder.hpp Co-authored-by: Andreas Stefl <[email protected]>
Co-authored-by: Andreas Stefl <[email protected]>
Co-authored-by: Andreas Stefl <[email protected]>
Co-authored-by: Andreas Stefl <[email protected]>
Co-authored-by: Andreas Stefl <[email protected]>
…etector/MockupSectorBuilder.hpp Co-authored-by: Andreas Stefl <[email protected]>
…etector/MockupSectorBuilder.hpp Co-authored-by: Andreas Stefl <[email protected]>
Co-authored-by: Andreas Stefl <[email protected]>
Co-authored-by: Andreas Stefl <[email protected]>
Co-authored-by: Noemi Calace <[email protected]>
Co-authored-by: Noemi Calace <[email protected]>
dimitra97
force-pushed
the
mockup-builder
branch
from
ec0ef9b to
47ee121
Compare
noemina
approved these changes
Apr 12, 2023
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates the mockup geometry with the chambers from a gdml file and extends the sector with the three chambers at phi. The picture
barrel_chambers000.pngshows the geometry in an obj file obtained by running theTestMockupBuilder.cppscript, which is also in the PR in order to reproduce the geometry.There is also some work in progress (e.g. python bindings)
@noemina @asalzburger