feat: Add Mlpack DBScan clustering to the ML Ambiguity solver #2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corentin-Allaire
added
Component - Core
Codecov Report
@@ Coverage Diff @@
## main #2005 +/- ##
==========================================
- Coverage 49.85% 49.81% -0.04%
==========================================
Files 419 420 +1
Lines 23857 23874 +17
Branches 10824 10835 +11
==========================================
Hits 11894 11894
- Misses 4349 4366 +17
Partials 7614 7614
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 8c1a266Full report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
andiwand
approved these changes
Apr 3, 2023
Core/include/Acts/TrackFinding/detail/AmbiguityTrackClustering.hpp
Outdated
Show resolved
Hide resolved
Examples/Algorithms/TrackFindingML/src/AmbiguityResolutionML.cpp
Outdated
Show resolved
Hide resolved
Plugins/mlpack/include/Acts/Plugins/mlpack/AmbiguityDBScanClustering.hpp
Show resolved
Hide resolved
|
Added |
|
who is this alex 279111a 👀 |
andiwand
approved these changes
Apr 11, 2023
I leave one week and now I don't know who is who anymore :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allow us to use the mlpack library inside Acts. This is a cpp library implementing many different ML algorithm. After this change we now have two implementation of the ML Solver, one using the hit based clustering and one based on the DBScan+hit based