fix: Track state range is invalid if tip index is #1995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the track state ranges to return zero-length ranges in case the tip index is kInvalid. The VectorTrackContainer backend initializes the `tipIndex` to kInvalid, and so does the `addTrack`, so in principle this should always be consistent by default.
|
Maybe you could review this @EdwardMoyse? |
📊 Physics performance monitoring for 3b58c8dFull report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
|
This looks good to me. |
EdwardMoyse
approved these changes
Mar 28, 2023
Codecov Report
@@ Coverage Diff @@
## main #1995 +/- ##
=======================================
Coverage 49.80% 49.80%
=======================================
Files 413 413
Lines 23596 23606 +10
Branches 10676 10681 +5
=======================================
+ Hits 11753 11758 +5
- Misses 4342 4343 +1
- Partials 7501 7505 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the track state ranges to return zero-length ranges in case the tip index is kInvalid. The VectorTrackContainer backend initializes the
tipIndexto kInvalid, and so does theaddTrack, so in principle this should always be consistent by default.Fixes #1994