-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Store unsigned 64bit integer for projector in MTJ backend #1958
Conversation
Only runs on the main branch, uses a secret trigger token to build it
This reverts commit 6531aac.
Codecov Report
@@ Coverage Diff @@
## main #1958 +/- ##
==========================================
- Coverage 49.60% 49.60% -0.01%
==========================================
Files 410 410
Lines 23297 23298 +1
Branches 10630 10631 +1
==========================================
Hits 11557 11557
Misses 4292 4292
- Partials 7448 7449 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for c838a7cFull report VertexingSeedingCKFAmbiguity resolutionTruth tracking (Kalman Filter)Truth tracking (GSF) |
I would argue not, because this looks like an implementation detail to me. Is there a reason why the |
I guess it could be, as the "public public" interface is independent of how it's stored, but the "private public" interface (the one the backends are built against) does require this to be known. I don't know, honestly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely ok from perspective of other ATLAS backend.
Side comment. I realised that probably calling these backend classes: *Backend would relay help in understanding the code.
Is this breaking?