Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add builds using C++20 #1957

Merged
merged 5 commits into from
Mar 17, 2023
Merged

Conversation

paulgessinger
Copy link
Member

The main workflow continues to run on C++17, but this adds variants to the extra build matrix that builds in C++20, too.

So we should now cover:

  • Ubuntu 20.04 + C++17
  • Ubuntu 22.04 + C++17 and C++20
  • Ubuntu 22.04 clang + C++17 and C++20

@paulgessinger paulgessinger added this to the next milestone Mar 17, 2023
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #1957 (d8a3b71) into main (b78feba) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1957   +/-   ##
=======================================
  Coverage   49.60%   49.60%           
=======================================
  Files         410      410           
  Lines       23297    23297           
  Branches    10630    10630           
=======================================
  Hits        11557    11557           
  Misses       4292     4292           
  Partials     7448     7448           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@github-actions
Copy link

📊 Physics performance monitoring for d8a3b71

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@benjaminhuth
Copy link
Member

Is there actually a plan to migrate to C++20 anytime soon?

@benjaminhuth benjaminhuth merged commit c1785e0 into acts-project:main Mar 17, 2023
@benjaminhuth benjaminhuth added the Infrastructure Changes to build tools, continous integration, ... label Mar 17, 2023
@paulgessinger paulgessinger deleted the cpp20_ci branch March 17, 2023 17:31
@paulgessinger
Copy link
Member Author

Nothing concrete yet, but I thought it doesn't hurt to check that we're ready in principle.

paulgessinger added a commit to paulgessinger/acts that referenced this pull request Mar 23, 2023
The main workflow continues to run on C++17, but this adds variants to
the `extra` build matrix that builds in C++20, too.

So we should now cover:
- Ubuntu 20.04 + C++17
- Ubuntu 22.04 + C++17 and C++20
- Ubuntu 22.04 clang + C++17 and C++20
@paulgessinger paulgessinger modified the milestones: next, v24.0.0 Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants