refactor: change in ITk seed confirmation for high pT muons efficiency

[LuisFelipeCoelho]

As discussed by @noemina in https://indico.cern.ch/event/1258598/contributions/5286608/attachments/2607062/4503967/UpgradeTracking_230308.pdf
and Athena MR https://gitlab.cern.ch:8443/atlas/athena/-/merge_requests/61367 this PR slightly changes the seed confirmation and ITk configuration (z binning and maximum distance between middle and bottom space points) to improve reconstruction for high pT muons

[github-actions]

📊 Physics performance monitoring for 3c414fa

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu

IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

[codecov]

Codecov Report

Merging #1956 (8ff6554) into main (4d7e280) will not change coverage.
The diff coverage is n/a.

❗ Current head 8ff6554 differs from pull request most recent head 3c414fa. Consider uploading reports for the commit 3c414fa to get more accurate results

@@           Coverage Diff           @@
##             main    #1956   +/-   ##
=======================================
  Coverage   49.80%   49.80%           
=======================================
  Files         413      413           
  Lines       23596    23596           
  Branches    10676    10676           
=======================================
  Hits        11753    11753           
  Misses       4342     4342           
  Partials     7501     7501           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[LuisFelipeCoelho]

The change in ITk performance is expected so I replaced the root hash

[LuisFelipeCoelho]

I guess I can close this PR since it was reverted in Athena @noemina

[LuisFelipeCoelho]

Or actually I will keep only the changes from Carlo's comment and the change in config

[CarloVarni]

@LuisFelipeCoelho news on this?

I see there are changes to the configuration, does that improve timing performance (how much?) while keeping high physics performance?

[LuisFelipeCoelho]

These config changes were also changed in Athena:
https://gitlab.cern.ch:8443/atlas/athena/-/merge_requests/61367
and then part of that MR was reverted in
https://gitlab.cern.ch:8443/atlas/athena/-/merge_requests/61666#160ad76ded943bf4a5cbf52a2e53d999a1c0ec3a
because of bad time performance.

The config changes don't seem to affect the performance too much

[CarloVarni]

just to confirm then... in Athena these changes produced worse performance? But in ACTS it is ok?

[LuisFelipeCoelho]

no, sorry. The seed confirmation changes in the first PR resulted in worse performance. These changes were reverted in Athena, but they kept the configuration changes, which does not affect performance too much.
Here in acts I am only applying the changes that were kept in Athena.