Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Switch main CI job to Ubuntu 22.04 #1955

Merged
merged 6 commits into from
Mar 17, 2023

Conversation

paulgessinger
Copy link
Member

I'm adding the old Ubuntu 20.04 job as an "extra" job, basically switching it out for the prior 22.04 one.

@paulgessinger paulgessinger added this to the next milestone Mar 16, 2023
@paulgessinger paulgessinger marked this pull request as ready for review March 16, 2023 17:56
@paulgessinger
Copy link
Member Author

Physmon and python level tests still fail, likely due to various version changes.

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #1955 (274c030) into main (dc94901) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1955      +/-   ##
==========================================
+ Coverage   49.56%   49.60%   +0.03%     
==========================================
  Files         410      410              
  Lines       22710    23297     +587     
  Branches    10367    10630     +263     
==========================================
+ Hits        11257    11557     +300     
- Misses       4241     4292      +51     
- Partials     7212     7448     +236     

see 202 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Mar 16, 2023

📊 Physics performance monitoring for 274c030

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@paulgessinger
Copy link
Member Author

IVF seeded:
diffz
image

IVF truth estimated:
diffz
image
recoz
image

IVF orthogonal:
recoz
image

GSF truth tracking:
resmean t vs eta
image


I think all of these changes are tolerable.

@benjaminhuth
Copy link
Member

I don't understand that GSF change. Seems also to happen in #1951

@benjaminhuth
Copy link
Member

I don't understand that GSF change. Seems also to happen in #1951

Okay, I see the same locally on main... not sure what could be the reason, I'll have a look at it.

Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@benjaminhuth benjaminhuth added Infrastructure Changes to build tools, continous integration, ... automerge labels Mar 17, 2023
@kodiakhq kodiakhq bot merged commit b78feba into acts-project:main Mar 17, 2023
@paulgessinger paulgessinger deleted the ubuntu22 branch March 17, 2023 11:43
paulgessinger added a commit to paulgessinger/acts that referenced this pull request Mar 23, 2023
I'm adding the old Ubuntu 20.04 job as an "extra" job, basically switching it out for the prior 22.04 one.
@paulgessinger paulgessinger modified the milestones: next, v24.0.0 Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants