feat: Added a function that draws the detector volume with inner surfaces

[dimitra97]

Added the drawDetectorVolumeWithSurfaces function that draws the detector volume with the sub-volumes and their surfaces . Any comments and recommendations are more than welcome.
@andiwand @Matthewharri @asalzburger

[codecov]

Codecov Report

Merging #1946 (f67221b) into main (95e3d9a) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1946      +/-   ##
==========================================
- Coverage   49.59%   49.57%   -0.02%     
==========================================
  Files         410      410              
  Lines       22697    22705       +8     
  Branches    10358    10366       +8     
==========================================
  Hits        11257    11257              
- Misses       4228     4236       +8     
  Partials     7212     7212              

Impacted Files	Coverage Δ
Core/src/Visualization/GeometryView3D.cpp	32.11% <0.00%> (-1.08%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

📊 Physics performance monitoring for f67221b

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu

IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

[andiwand]

I wonder if we should combine this with drawDetectorVolume somehow or just create a new function as you did. maybe @Matthewharri has some input for us

other than that you should reformat the code using clang-format so it aligns with the rest of the code and the CI will stop complaining

[Matthewharri]

I think it might be best to have it combined with drawDetectorVolume somehow like @andiwand mentioned. But I do have a question, if you're drawing the portals, shouldn't that be all that is needed to draw the DetectorVolume? Or am I missing something obvious?

[dimitra97]

I think it might be best to have it combined with drawDetectorVolume somehow like @andiwand mentioned. But I do have a question, if you're drawing the portals, shouldn't that be all that is needed to draw the DetectorVolume? Or am I missing something obvious?

[andiwand]

I think it might be best to have it combined with drawDetectorVolume somehow like @andiwand mentioned. But I do have a question, if you're drawing the portals, shouldn't that be all that is needed to draw the DetectorVolume? Or am I missing something obvious?

thanks for the feedback @Matthewharri ! each detector volume has a list of portals and surfaces where the surfaces represent material or sensitive elements of the detector. is it okay for you if we plot all the surfaces all the time or should we flag it so you can also just plot the portals as it used to be

[Matthewharri]

@andiwand Thanks for the explanation, that makes sense. I think it should be fine either way, so really whatever you prefer

[andiwand]

@dimitra97 if you apply my suggested change we can merge this in

[dimitra97]

@dimitra97 if you apply my suggested change we can merge this in

sure! i applied

[andiwand]

👍