fix: Compute complete covariance for max weight reduction #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminhuth
added
Component - Core
Codecov Report
@@ Coverage Diff @@
## main #1927 +/- ##
==========================================
- Coverage 49.66% 49.66% -0.01%
==========================================
Files 409 409
Lines 22651 22661 +10
Branches 10339 10347 +8
==========================================
+ Hits 11250 11254 +4
+ Misses 4196 4195 -1
- Partials 7205 7212 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 383e58fFull report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
|
This should be again a improvement:
|
andiwand
approved these changes
Mar 13, 2023
Maury98
pushed a commit
to Maury98/acts
that referenced
this pull request
Mar 28, 2023
…ct#1927) In case of returning the parameters of the component with the largest weight, it is of course not correct to return also the covariance matrix of this component, since it does not reflect the uncertainty of the whole distribution. Rather, return the the covariance computed from all components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of returning the parameters of the component with the largest weight, it is of course not correct to return also the covariance matrix of this component, since it does not reflect the uncertainty of the whole distribution. Rather, return the the covariance computed from all components.