Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: raise RuntimeError if invalid inputSpacePointsType in ITk configuration #1902

Merged
merged 5 commits into from
Mar 5, 2023
Merged

feat: raise RuntimeError if invalid inputSpacePointsType in ITk configuration #1902

merged 5 commits into from
Mar 5, 2023

Conversation

LuisFelipeCoelho
Copy link
Member

No description provided.

@LuisFelipeCoelho LuisFelipeCoelho changed the title raise RuntimeError if invalid inputSpacePointsType in ITk configuration feat: raise RuntimeError if invalid inputSpacePointsType in ITk configuration Feb 28, 2023
@LuisFelipeCoelho LuisFelipeCoelho added the Component - Examples Affects the Examples module label Feb 28, 2023
@LuisFelipeCoelho LuisFelipeCoelho added this to the next milestone Feb 28, 2023
@codecov
Copy link

codecov bot commented Feb 28, 2023 •
edited
Loading

Codecov Report

Merging #1902 (700c065) into main (2d6f99d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1902   +/-   ##
=======================================
  Coverage   49.48%   49.48%           
=======================================
  Files         408      408           
  Lines       22704    22704           
  Branches    10363    10363           
=======================================
  Hits        11236    11236           
  Misses       4257     4257           
  Partials     7211     7211

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Mar 1, 2023 •
edited
Loading

📊 Physics performance monitoring for 700c065

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

AJPfleger
AJPfleger approved these changes Mar 5, 2023
View reviewed changes
Copy link
Contributor

@AJPfleger AJPfleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kodiakhq kodiakhq bot merged commit b0abc04 into acts-project:main Mar 5, 2023
@github-actions github-actions bot removed the automerge label Mar 5, 2023
@paulgessinger paulgessinger modified the milestones: next, v23.5.0 Mar 10, 2023
@LuisFelipeCoelho LuisFelipeCoelho deleted the bug_itk_csv_example branch May 11, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AJPfleger AJPfleger AJPfleger approved these changes

@andiwand andiwand Awaiting requested review from andiwand

Assignees
No one assigned
Labels
Component - Examples Affects the Examples module
Projects
None yet
Milestone
v23.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@LuisFelipeCoelho @AJPfleger @paulgessinger