refactor: and fix truth seeding

[andiwand]

truth seeding seems to be quite broken at the moment

1. you could end up with less sees than particles which will crash the kalman filter downstream
2. the proto tracks given by the seeding seem to only contain the seeded hits which is no good for the kalman filter

with this PR I tried to improve things by splitting the truth seeding out of TrackParamsEstimationAlgorithm and restore its original purpose. I added TruthSeedingAlgorithm which now also does TruthTrackFinder in order to keep seeded particles and track params aligned

[codecov]

Codecov Report

Merging #1897 (d74905f) into main (208290d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1897   +/-   ##
=======================================
  Coverage   49.44%   49.44%           
=======================================
  Files         408      408           
  Lines       22704    22704           
  Branches    10371    10371           
=======================================
  Hits        11226    11226           
  Misses       4266     4266           
  Partials     7212     7212           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

📊 Physics performance monitoring for d74905f

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu

IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

[benjaminhuth]

Really nice changes, I also always had the impression that thisTrackParamEstimationAlgorithm served way to many purposes! I just have one minor comment about naming.

[benjaminhuth]

I think we should try to make this refactoring in a way that the hashes stay the same, right? Currently quite a lot of hash checks still fail.

[andiwand]

will try to do that. physmon looks also kind of sketchy. but I wonder if we also did 3 hit fitting in the tests

[benjaminhuth]

If we do 3 hit fitting, maybe change that in a follow-up PR? that way we can be sure that we have no change in behaviour in this refactoring...

[andiwand]

almost done - looks like we had two reference files which only took the seed proto tracks as an input but should have taken the full track actually it is the other way around. the seeding performance output was writing the full track but should write only the seeded hits

I may remove the proto tracks from the seeds in a follow up PR

now it should be down to physmon which is picking on the truth estimated seeding efficiency. I believe we measured this in a wrong way which resulted in a 100% efficiency but it is actually a little lower than that because we apply some cuts in the truth seeding

[andiwand]

this should be ready now @benjaminhuth @asalzburger

[benjaminhuth]

Very nice refactoring, let's get it in!

[asalzburger]

As discussed, makes perfect sense.