Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add script checking for #pragma once to CI #1866

Merged
merged 6 commits into from
Feb 15, 2023

Conversation

benjaminhuth
Copy link
Member

@benjaminhuth benjaminhuth commented Feb 15, 2023

I noticed a missing #pragma once in a file in Core, and thought it would be nice to check this in the CI.

@benjaminhuth benjaminhuth added the Infrastructure Changes to build tools, continous integration, ... label Feb 15, 2023
@benjaminhuth benjaminhuth added this to the next milestone Feb 15, 2023
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea to me!

Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

looks like we are missing some includes now which cascaded through before

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #1866 (2707923) into main (2a5c4d5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1866   +/-   ##
=======================================
  Coverage   49.50%   49.50%           
=======================================
  Files         407      407           
  Lines       22646    22646           
  Branches    10334    10334           
=======================================
  Hits        11210    11210           
  Misses       4247     4247           
  Partials     7189     7189           
Impacted Files Coverage Δ
Core/include/Acts/Utilities/Zip.hpp 90.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

📊 Physics performance monitoring for 2707923

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@kodiakhq kodiakhq bot merged commit d857080 into acts-project:main Feb 15, 2023
@paulgessinger paulgessinger modified the milestones: next, v23.3.0 Feb 21, 2023
@benjaminhuth benjaminhuth deleted the ci/fix-missing-pragma-once branch February 22, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants