-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: persist ACTS barcodes in G4 sim #1842
Conversation
📊 Physics performance monitoring for 2f172d3Full report VertexingSeedingCKFAmbiguity resolutionTruth tracking (Kalman Filter)Truth tracking (GSF) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nicely done! I think we're getting closer to make Geant4 a drop-in replacement of FATRAS!
Codecov Report
@@ Coverage Diff @@
## main #1842 +/- ##
=======================================
Coverage 49.50% 49.50%
=======================================
Files 407 407
Lines 22646 22646
Branches 10334 10334
=======================================
Hits 11210 11210
Misses 4247 4247
Partials 7189 7189 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Just to confirm: I suppose this fixes these errors?
|
yeah exactly @pbutti. the particle IDs haven't been persistent until now which confuses all the performance writers we may also need a particle selector after the simulation because most of the secondary particles will not be reconstructible and will currently ruin all the performance results (as discussed with @paulgessinger yesterday) |
Hi, looks like this needs an update of the reference for the Geant4 example - not surprising. |
…o feature-g4sim-barcodes
makes sense - should be fixed now |
as discovered in #1842 we should filter particles before and after simulation especially with geant4 as we get a lot of secondaries
particle barcodes did not make sense after G4 sim because they were just counted upwards without paying attention to the semantics of the bits in the barcode.
this pr adds persistence to the barcodes by storing a mapping in the G4 specific event store. also the particle generation counter is increased with each secondary process