Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change templates order for labelClusters #1827

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

CarloVarni
Copy link
Collaborator

Connected to #1825

Not sure if this closes that issue or it needs more investigation by @gagnonlg , but without this PR I cannot compile clustering with v23 in Athena

/cc @paulgessinger

@CarloVarni CarloVarni added the Bug Something isn't working label Feb 5, 2023
@CarloVarni CarloVarni added this to the next milestone Feb 5, 2023
@github-actions
Copy link

github-actions bot commented Feb 5, 2023

📊 Physics performance monitoring for 0f85c8f

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@codecov
Copy link

codecov bot commented Feb 5, 2023

Codecov Report

Merging #1827 (0f85c8f) into main (2c7b63f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1827   +/-   ##
=======================================
  Coverage   49.53%   49.53%           
=======================================
  Files         407      407           
  Lines       22629    22629           
  Branches    10326    10326           
=======================================
  Hits        11210    11210           
  Misses       4230     4230           
  Partials     7189     7189           
Impacted Files Coverage Δ
...ore/include/Acts/Clusterization/Clusterization.ipp 80.73% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gagnonlg
Copy link
Contributor

gagnonlg commented Feb 6, 2023

Looks good to me, thanks @CarloVarni. So there was a mismatch between the declaration in the .hpp and .ipp. I would have thought it would have been caught by the compiler but seems like it saw it as an overload.

@gagnonlg
Copy link
Contributor

gagnonlg commented Feb 6, 2023

Closes #1825

@kodiakhq kodiakhq bot merged commit 3549bb1 into acts-project:main Feb 6, 2023
@github-actions github-actions bot removed the automerge label Feb 6, 2023
@CarloVarni CarloVarni deleted the clusterTemplates branch February 6, 2023 08:59
@paulgessinger paulgessinger modified the milestones: next, v23.2.0 Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants