Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fix build with external nlohmann_json #1806

Merged
merged 3 commits into from
Jan 30, 2023

Conversation

paulgessinger
Copy link
Member

Found a residual un-namespaced target we linked against. Only exists if we build nlohmann_json ourselves.

Found a residual un-namespaced target we linked against. Only exists if
we build nlohmann_json ourselves.
@paulgessinger paulgessinger added this to the next milestone Jan 30, 2023
@github-actions
Copy link

github-actions bot commented Jan 30, 2023

📊 Physics performance monitoring for f866209

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #1806 (f866209) into main (a7f5728) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1806   +/-   ##
=======================================
  Coverage   49.55%   49.55%           
=======================================
  Files         407      407           
  Lines       22625    22625           
  Branches    10321    10321           
=======================================
  Hits        11211    11211           
  Misses       4230     4230           
  Partials     7184     7184           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andiwand andiwand self-assigned this Jan 30, 2023
@kodiakhq kodiakhq bot merged commit c6fcdb8 into acts-project:main Jan 30, 2023
@paulgessinger paulgessinger modified the milestones: next, v23.1.0 Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants