Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: G4 plugin material mixing #1805

Merged
merged 4 commits into from
Jan 31, 2023
Merged

feat: G4 plugin material mixing #1805

merged 4 commits into from
Jan 31, 2023

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand added Impact - Minor Nuissance bug and/or affects only a single module Component - Plugins Affects one or more Plugins labels Jan 27, 2023
@andiwand andiwand added this to the next milestone Jan 27, 2023
@andiwand andiwand requested a review from asalzburger January 27, 2023 13:08
@andiwand andiwand mentioned this pull request Jan 27, 2023
Merged
@andiwand andiwand changed the title feature: G4 plugin material mixing feat: G4 plugin material mixing Jan 27, 2023
@codecov
Copy link

codecov bot commented Jan 27, 2023 •
edited
Loading

Codecov Report

Merging #1805 (13dec8b) into main (b1e5cf2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1805   +/-   ##
=======================================
  Coverage   49.55%   49.55%           
=======================================
  Files         407      407           
  Lines       22625    22625           
  Branches    10321    10321           
=======================================
  Hits        11211    11211           
  Misses       4230     4230           
  Partials     7184     7184

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jan 27, 2023 •
edited
Loading

📊 Physics performance monitoring for 13dec8b

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

asalzburger
asalzburger approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@asalzburger asalzburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's how it should be.

@asalzburger asalzburger merged commit 83f43a2 into acts-project:main Jan 31, 2023
@andiwand andiwand deleted the feature-g4-plugin-material-mixing branch February 1, 2023 08:58
@paulgessinger paulgessinger modified the milestones: next, v23.1.0 Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asalzburger asalzburger asalzburger approved these changes

Assignees
No one assigned
Labels
Component - Plugins Affects one or more Plugins Impact - Minor Nuissance bug and/or affects only a single module
Projects
None yet
Milestone
v23.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@andiwand @asalzburger @paulgessinger