Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Linkage errors in BetheHeitlerApprox.hpp #1777

Conversation

benjaminhuth
Copy link
Member

This should fix violations of ODR by either adding the inline keyword or by moving functions to a cpp file.

@benjaminhuth benjaminhuth added Bug Something isn't working Component - Core Affects the Core module labels Jan 9, 2023
@benjaminhuth benjaminhuth added this to the next milestone Jan 9, 2023
@benjaminhuth benjaminhuth requested a review from andiwand January 9, 2023 07:14
Copy link
Contributor

@AJPfleger AJPfleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #1777 (e5099c0) into main (ae2811f) will increase coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #1777      +/-   ##
==========================================
+ Coverage   49.66%   49.67%   +0.01%     
==========================================
  Files         403      404       +1     
  Lines       22406    22401       -5     
  Branches    10240    10240              
==========================================
  Hits        11127    11127              
+ Misses       4135     4130       -5     
  Partials     7144     7144              
Impacted Files Coverage Δ
...e/include/Acts/TrackFitting/BetheHeitlerApprox.hpp 24.00% <0.00%> (-0.57%) ⬇️
Core/src/TrackFitting/BetheHeitlerApprox.cpp 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

📊 Physics performance monitoring for e5099c0

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@kodiakhq kodiakhq bot merged commit a58b798 into acts-project:main Jan 9, 2023
@github-actions github-actions bot removed the automerge label Jan 9, 2023
@benjaminhuth benjaminhuth deleted the fix/bethe-heitler-move-functions-to-cpp branch January 10, 2023 09:24
Maury98 pushed a commit to Maury98/acts that referenced this pull request Jan 12, 2023
This should fix violations of ODR by either adding the `inline` keyword or by moving functions to a cpp file.
@paulgessinger paulgessinger modified the milestones: next, v23.0.0 Jan 18, 2023
acts-project-service pushed a commit that referenced this pull request Jan 18, 2023
This should fix violations of ODR by either adding the `inline` keyword or by moving functions to a cpp file.

(cherry picked from commit a58b798)
kodiakhq bot pushed a commit that referenced this pull request Jan 18, 2023
…lop/v20.x] (#1788)

Backport a58b798 from #1777.
---
This should fix violations of ODR by either adding the `inline` keyword or by moving functions to a cpp file.

Co-authored-by: Benjamin Huth <[email protected]>
acts-project-service pushed a commit that referenced this pull request Jan 25, 2023
This should fix violations of ODR by either adding the `inline` keyword or by moving functions to a cpp file.

(cherry picked from commit a58b798)
paulgessinger pushed a commit that referenced this pull request Jan 26, 2023
…lop/v21.1.x] (#1800)

Backport a58b798 from #1777.
---
This should fix violations of ODR by either adding the `inline` keyword
or by moving functions to a cpp file.

Co-authored-by: Benjamin Huth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants