Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: physmon vertexing #1688

Merged
merged 7 commits into from
Jan 24, 2023
Merged

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Nov 23, 2022

rearranges vertexing code in physmon a little

@andiwand andiwand added Infrastructure Changes to build tools, continous integration, ... Component - Examples Affects the Examples module 🚧 WIP Work-in-progress labels Nov 23, 2022
@andiwand andiwand added this to the next milestone Nov 23, 2022
@andiwand andiwand force-pushed the fix-physmon-vertexing branch from 52056db to 37fdcc8 Compare November 23, 2022 12:29
@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #1688 (13be5ca) into main (7a3761d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1688   +/-   ##
=======================================
  Coverage   49.54%   49.54%           
=======================================
  Files         407      407           
  Lines       22618    22618           
  Branches    10318    10318           
=======================================
  Hits        11207    11207           
  Misses       4230     4230           
  Partials     7181     7181           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Nov 23, 2022

📊 Physics performance monitoring for 13be5ca

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@andiwand andiwand changed the title fix: physmon vertexing refactor: physmon vertexing Dec 13, 2022
@andiwand andiwand removed the 🚧 WIP Work-in-progress label Dec 13, 2022
@andiwand andiwand marked this pull request as ready for review December 13, 2022 09:36
@stale
Copy link

stale bot commented Jan 16, 2023

This issue/PR has been automatically marked as stale because it has not had recent activity. The stale label will be removed if any interaction occurs.

@stale stale bot added the Stale label Jan 16, 2023
@paulgessinger
Copy link
Member

This didn't get a review yet. @andiwand can you remove the conflicts?

@andiwand
Copy link
Contributor Author

I removed the conflicts @paulgessinger

@kodiakhq kodiakhq bot merged commit 03498c5 into acts-project:main Jan 24, 2023
@andiwand andiwand deleted the fix-physmon-vertexing branch January 24, 2023 14:50
@paulgessinger paulgessinger removed this from the next milestone Feb 2, 2023
@paulgessinger paulgessinger added this to the v23.1.0 milestone Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants