Use HierarchicalGeometryContainer to simplfiy CKF source link selection #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiaocongAi
changed the title
Codecov Report
@@ Coverage Diff @@
## master #168 +/- ##
==========================================
+ Coverage 46.01% 46.04% +0.02%
==========================================
Files 353 353
Lines 17664 17646 -18
Branches 8220 8209 -11
==========================================
- Hits 8128 8125 -3
+ Misses 4319 4312 -7
+ Partials 5217 5209 -8
Continue to review full report at Codecov.
|
XiaocongAi
added
Component - Core
|
Hi @msmk0 , could you help take a look at this PR to see if the |
XiaocongAi
force-pushed
the
simplify_source_link_selection
branch
from
bcbfb59 to
aa040c8
Compare
msmk0
suggested changes
May 5, 2020
Tests/UnitTests/Core/TrackFinder/CombinatorialKalmanFilterTests.cpp
Outdated
Show resolved
Hide resolved
XiaocongAi
force-pushed
the
simplify_source_link_selection
branch
from
aa040c8 to
285ad9a
Compare
msmk0
approved these changes
May 6, 2020
msmk0
approved these changes
May 6, 2020
|
I approved the changes and the CI build runs through, but I can not merge. It looks like some checks are blocking it. Not sure what to do in that case. @paulgessinger Suggestions? |
paulgessinger
approved these changes
May 6, 2020
|
Seems to have been a communication problem with the bots. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplify the CKF source link selection by using the hierarchical geometry container for the selection criteria.