-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only build Core+Tests in the macOS CI build #141
Conversation
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
=======================================
Coverage 45.79% 45.79%
=======================================
Files 349 349
Lines 17395 17395
Branches 8071 8071
=======================================
Hits 7966 7966
Misses 4332 4332
Partials 5097 5097 Continue to review full report at Codecov.
|
I’ve got the dependency build running. Should be able to reenable this right away |
Ok. Can you create a PR for the necessary changes. Then I will close this one. |
The CI job in the other repository now builds all dependencies. I still need to test if our code builds on top of that (which I expect should work), and then switch over the tarball URL in the macOS job here. I'll do that as soon as I have it. |
Ok so it seems not to be possible to convince DD4hep's invocation of DD4hep doesn't seem to have any issues finding root, even if the location is different as when DD4hep was built, so this points to being a 'problem' with Honestly, I don't know what to do here. I can still make the deps CI deploy up-to-date versions of DD4hep, G4, root and so on, and the CI in this repo can pick that up, but that's not at all a synchronized process here, and could be fragile. |
I would suggest we merge this change in, then. That way we compile at least the core on macOS for now. We can discuss options next week without having a broken build. |
TGeo should be fine though? |
That requires ROOT which is not available via homebrew, correct? |
But it is available from the tarball that the CI currently downloads. |
Won't we have the same problem that we have with Geant4 now, i.e. ROOT depends on a library from homebrew (expat or something similar) with a version-specific path that will break in the future? |
Hi, I agree with the strategy here - if we have a macOS build for the Core, that should be fine.
Let's quickly discuss in the briefing tomorrow, but I would tend to approve and merge as such then. |
This reverts commit 878e148.
This (temporarily) disables building the examples and the DD4hep- and TGeo plugin. This sidesteps the build issue with the additional HEP-specific dependencies (ROOT, Geant4, DD4hep, ...).