Fix the coverage job #136
Merged
Fix the coverage job #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulgessinger
added
the
Infrastructure
|
Eventually, this will fail if our build size grows any larger, but immediately, I hope that fixes the problem. |
Merged
asalzburger
approved these changes
Apr 24, 2020
|
Overriding macOS build failure. |
osbornjd
pushed a commit
to sPHENIX-Collaboration/acts
that referenced
this pull request
Apr 29, 2020
* try to remove .o files after unit test run in coverage job * report size * try azure * pipe * pr * azure: build and run * names * use find to delete .o files * remove azure config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the reason why the coverage job stopped working was our build output size. After running the unit tests with coverage on, I know delete all
.ofiles, since for the report they are not needed anymore. This takes the build size down to about 5G from 10G, which makes the job succeed again in my testing.