-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Combinatorial Kalman Filter #102
Implement Combinatorial Kalman Filter #102
Conversation
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
==========================================
- Coverage 44.50% 42.98% -1.53%
==========================================
Files 357 354 -3
Lines 17592 17147 -445
Branches 8260 8130 -130
==========================================
- Hits 7830 7371 -459
- Misses 4807 4824 +17
+ Partials 4955 4952 -3
Continue to review full report at Codecov.
|
This looks like a ton of work! Had a quick look and I think it looks really good. I'll try to have a closer look as soon as possible, but if anyone else wants to have a look, go ahead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the tons of comments, but it's a huge amount of code. Looks like awesome work! Will approve once we resolve the discussion items.
7aac56a
to
8e28e01
Compare
I think the |
8858c14
to
e504bb0
Compare
@paulgessinger Thank you for your good suggestions for this PR! I have updated/optimized the code as much as possible. Will rebase it tomorrow. |
…it's always the last element of activeTips)
… in different scenario
e504bb0
to
7eb0aa8
Compare
Approval is out! |
The CI fails because it points a commit that was most likely force pushed away. @XiaocongAi can you rebase and/or push an empty commit to trigger a complete pipeline? |
@XiaocongAi - if you rebase & push, I will merge in later. |
@asalzburger . it's rebased. But the CI fails due to "No space left on device". How could I deal with this? |
Hm, I saw this message before, but if I check the log now I still see
That is not the tip of the branch however, I believe. Not sure why that job tries to check that ref out. |
I override the coverage failure, because I think it's a technical problem, which I don't want to hold this PR back for. (See #124) |
This MR includes the following: