-
Notifications
You must be signed in to change notification settings - Fork 176
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor: Split particle selection in Examples (#3969)
- split particle selection into three stages: after generation, after simulation, after digitization - this allows to perform cuts on the particle collections independent from the algorithms processing them - after digitization cuts allow to cut on measurement count - elevates particle selection into reconstruction chain blocked by - #4035 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit # Release Notes: Particle Processing and Naming Convention Update ## Overview This release introduces significant improvements to particle processing workflows, focusing on more precise particle selection and standardized naming conventions. ## Key Changes ### Particle Selection - Added new functions for particle selection at different stages: - `addGenParticleSelection`: Selects particles during generation - `addSimParticleSelection`: Selects particles during simulation - `addDigiParticleSelection`: Selects particles during digitization ### Naming Conventions - Updated particle-related variable names from `particles_input` to `particles_generated` - Standardized input/output particle identifiers across multiple scripts and workflows ### Particle Filtering - Simplified particle selection logic - Removed inline particle selection configurations - Enhanced modularity in particle processing ## Impact - Improved clarity in particle handling - More flexible and consistent particle selection - Better separation of concerns in simulation workflows <!-- end of auto-generated comment: release notes by coderabbit.ai -->
- Loading branch information
Showing
34 changed files
with
420 additions
and
374 deletions.
There are no files selected for viewing
Binary file modified
BIN
+496 Bytes
(100%)
CI/physmon/reference/simulation/particles_fatras_hist.root
Binary file not shown.
Binary file modified
BIN
+779 Bytes
(100%)
CI/physmon/reference/simulation/particles_geant4_hist.root
Binary file not shown.
Binary file modified
BIN
+68 Bytes
(100%)
...smon/reference/trackfinding_ttbar_pu200/performance_vertexing_amvf_gauss_notime_hist.root
Binary file not shown.
Binary file modified
BIN
+62 Bytes
(100%)
CI/physmon/reference/trackfinding_ttbar_pu200/performance_vertexing_amvf_grid_time_hist.root
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.