Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Efecty icon and configuration #1258

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: add Efecty icon and configuration #1258

wants to merge 2 commits into from

Conversation

fscharf
Copy link

@fscharf fscharf commented Nov 27, 2024 •
edited
Loading

Why are you adding this icons?

I'm adding/updating this icon(s) because it is needed in order to accomplish Mercado Pago checkout payment method icons.

Help us identify yourself

  • I'm working/collaborating with the brand directly and they have provided the icons.
  • I'm associated with the brand and I've read all the brand icon’s guidelines.
  • I'm an individual and I've read all the brand icon’s guidelines.

Link to the brand guidelines:

Checklist to add new icons

  • All icons have a corresponding entry in db/payment_icons.yml
  • I have followed the icon guidelines detailed in the CONTRIBUTING.md file
  • I have optimized the icon with SVGO
  • I am confident that all icons are clear and easy to read/understand
  • I have provided a link to the brand icon’s brand guidelines whenever possible.
  • I have attached a screenshot comparison with the example icon provided in guidelines
  • I recognize that if my icon is not approved by the Shopify Partners team it may not receive review nor merger.

If this pull request is not adding new icons, you can remove this checklist.

Attach a screenshot of the icon along side the example Visa icon

Screenshot 2024-11-27 at 1 55 13 PM Screenshot 2024-11-27 at 1 54 38 PM

Tips how to create a screenshot

We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.

<!-- Change background color if needed to showcase your icon better -->
<style> body { background: black; } </style>

<!-- DO NOT DELETE EXAMPLE -->
<svg viewBox="0 0 38 24" xmlns="http://www.w3.org/2000/svg" role="img" width="38" height="24" aria-labelledby="pi-visa"><title id="pi-visa">Visa</title><path opacity=".07" d="M35 0H3C1.3 0 0 1.3 0 3v18c0 1.7 1.4 3 3 3h32c1.7 0 3-1.3 3-3V3c0-1.7-1.4-3-3-3z"/><path fill="#fff" d="M35 1c1.1 0 2 .9 2 2v18c0 1.1-.9 2-2 2H3c-1.1 0-2-.9-2-2V3c0-1.1.9-2 2-2h32"/><path d="M28.3 10.1H28c-.4 1-.7 1.5-1 3h1.9c-.3-1.5-.3-2.2-.6-3zm2.9 5.9h-1.7c-.1 0-.1 0-.2-.1l-.2-.9-.1-.2h-2.4c-.1 0-.2 0-.2.2l-.3.9c0 .1-.1.1-.1.1h-2.1l.2-.5L27 8.7c0-.5.3-.7.8-.7h1.5c.1 0 .2 0 .2.2l1.4 6.5c.1.4.2.7.2 1.1.1.1.1.1.1.2zm-13.4-.3l.4-1.8c.1 0 .2.1.2.1.7.3 1.4.5 2.1.4.2 0 .5-.1.7-.2.5-.2.5-.7.1-1.1-.2-.2-.5-.3-.8-.5-.4-.2-.8-.4-1.1-.7-1.2-1-.8-2.4-.1-3.1.6-.4.9-.8 1.7-.8 1.2 0 2.5 0 3.1.2h.1c-.1.6-.2 1.1-.4 1.7-.5-.2-1-.4-1.5-.4-.3 0-.6 0-.9.1-.2 0-.3.1-.4.2-.2.2-.2.5 0 .7l.5.4c.4.2.8.4 1.1.6.5.3 1 .8 1.1 1.4.2.9-.1 1.7-.9 2.3-.5.4-.7.6-1.4.6-1.4 0-2.5.1-3.4-.2-.1.2-.1.2-.2.1zm-3.5.3c.1-.7.1-.7.2-1 .5-2.2 1-4.5 1.4-6.7.1-.2.1-.3.3-.3H18c-.2 1.2-.4 2.1-.7 3.2-.3 1.5-.6 3-1 4.5 0 .2-.1.2-.3.2M5 8.2c0-.1.2-.2.3-.2h3.4c.5 0 .9.3 1 .8l.9 4.4c0 .1 0 .1.1.2 0-.1.1-.1.1-.1l2.1-5.1c-.1-.1 0-.2.1-.2h2.1c0 .1 0 .1-.1.2l-3.1 7.3c-.1.2-.1.3-.2.4-.1.1-.3 0-.5 0H9.7c-.1 0-.2 0-.2-.2L7.9 9.5c-.2-.2-.5-.5-.9-.6-.6-.3-1.7-.5-1.9-.5L5 8.2z" fill="#142688"/></svg>

<!-- TODO: insert your icon here -->
<svg xmlns="http://www.w3.org/2000/svg" width="38" height="24" role="img" aria-labelledby="pi-efecty" viewBox="0 0 38 24" fill="none"><title id="pi-efecty">Efecty</title><g clip-path="url(#clip0_3427_6721)"><path opacity=".07" d="M35 0H3C1.3 0 0 1.3 0 3v18c0 1.7 1.4 3 3 3h32c1.7 0 3-1.3 3-3V3c0-1.7-1.4-3-3-3z" fill="#000"/><path d="M35 1c1.1 0 2 .9 2 2v18c0 1.1-.9 2-2 2H3c-1.1 0-2-.9-2-2V3c0-1.1.9-2 2-2h32z" fill="#fff"/><path fill-rule="evenodd" clip-rule="evenodd" d="M23.455 3.296C26.812 4.5 28.759 7.945 28.004 12c-.88 4.728-5.116 8.62-9.718 9.116-.366-.012-.371-.224-.383-.538.018-.654.041-1.314.059-1.968.006-.096-.03-.127-.071-.139a7.036 7.036 0 01-1.398-.302c-.496-.2-.997-.49-1.499-.824-.23-.115-.2-.66-.195-.871.042-.388.319-1.29.767-1.332.537-.03.79.26 1.322.527.932.454 2.236.72 3.204.254.466-.29.578-.684.36-1.18-.378-.812-2.19-1.478-3.01-1.883-1.964-.86-3.062-2.603-2.713-4.68.26-1.53 1.657-2.693 3.12-2.905v-.732c-1.805.538-3.18 1.604-4.413 2.845-1.787 1.791-2.838 4.055-2.926 6.949.142 3.541 1.935 5.109 3.811 6.283C11.1 19.343 9.26 15.965 9.997 12c.902-4.854 5.34-8.825 10.089-9.146.189.115.2.133.3.393-.04.612-.076 1.223-.117 1.834.938.194 1.823.466 2.537 1.09.023 1.404-1.003 1.991-1.393 1.78.018-.067-1.546-.509-1.87-.588-.395-.066-.785-.042-1.174.14-.46.224-.679.557-.46 1.077.189.388.501.642.843.86.986.545 1.971 1.095 2.957 1.64.849.49 1.457 1.126 1.846 1.895.283.763.348 1.537.183 2.324-.195.642-.43 1.199-.79 1.55-.302.35-.632.623-.986.817-.502.273-1.003.515-1.522.6-.018.326-.03.647-.047.974.041.024.082.012.13 0 1.115-.37 2.094-1.017 3.05-1.725 1.239-1.12 2.395-2.294 3.003-3.814a9.462 9.462 0 00.885-2.887c.336-3.087-.761-5.993-4.006-7.518zM20.865 2c5.422 0 8.986 4.473 7.959 10-1.027 5.527-6.26 10-11.683 10-5.428 0-8.991-4.473-7.965-10 1.033-5.527 6.26-10 11.689-10z" fill="#020203"/></g><defs><clipPath id="clip0_3427_6721"><path fill="#fff" d="M0 0h38v24H0z"/></clipPath></defs></svg>

<br>
<!-- TODO: insert your icon here -->
<svg xmlns="http://www.w3.org/2000/svg" width="38" height="24" role="img" aria-labelledby="pi-efecty" viewBox="0 0 38 24" fill="none"><title id="pi-efecty">Efecty</title><g clip-path="url(#clip0_3427_6721)"><path opacity=".07" d="M35 0H3C1.3 0 0 1.3 0 3v18c0 1.7 1.4 3 3 3h32c1.7 0 3-1.3 3-3V3c0-1.7-1.4-3-3-3z" fill="#000"/><path d="M35 1c1.1 0 2 .9 2 2v18c0 1.1-.9 2-2 2H3c-1.1 0-2-.9-2-2V3c0-1.1.9-2 2-2h32z" fill="#fff"/><path fill-rule="evenodd" clip-rule="evenodd" d="M23.455 3.296C26.812 4.5 28.759 7.945 28.004 12c-.88 4.728-5.116 8.62-9.718 9.116-.366-.012-.371-.224-.383-.538.018-.654.041-1.314.059-1.968.006-.096-.03-.127-.071-.139a7.036 7.036 0 01-1.398-.302c-.496-.2-.997-.49-1.499-.824-.23-.115-.2-.66-.195-.871.042-.388.319-1.29.767-1.332.537-.03.79.26 1.322.527.932.454 2.236.72 3.204.254.466-.29.578-.684.36-1.18-.378-.812-2.19-1.478-3.01-1.883-1.964-.86-3.062-2.603-2.713-4.68.26-1.53 1.657-2.693 3.12-2.905v-.732c-1.805.538-3.18 1.604-4.413 2.845-1.787 1.791-2.838 4.055-2.926 6.949.142 3.541 1.935 5.109 3.811 6.283C11.1 19.343 9.26 15.965 9.997 12c.902-4.854 5.34-8.825 10.089-9.146.189.115.2.133.3.393-.04.612-.076 1.223-.117 1.834.938.194 1.823.466 2.537 1.09.023 1.404-1.003 1.991-1.393 1.78.018-.067-1.546-.509-1.87-.588-.395-.066-.785-.042-1.174.14-.46.224-.679.557-.46 1.077.189.388.501.642.843.86.986.545 1.971 1.095 2.957 1.64.849.49 1.457 1.126 1.846 1.895.283.763.348 1.537.183 2.324-.195.642-.43 1.199-.79 1.55-.302.35-.632.623-.986.817-.502.273-1.003.515-1.522.6-.018.326-.03.647-.047.974.041.024.082.012.13 0 1.115-.37 2.094-1.017 3.05-1.725 1.239-1.12 2.395-2.294 3.003-3.814a9.462 9.462 0 00.885-2.887c.336-3.087-.761-5.993-4.006-7.518zM20.865 2c5.422 0 8.986 4.473 7.959 10-1.027 5.527-6.26 10-11.683 10-5.428 0-8.991-4.473-7.965-10 1.033-5.527 6.26-10 11.689-10z" fill="#020203"/></g><defs><clipPath id="clip0_3427_6721"><path fill="#fff" d="M0 0h38v24H0z"/></clipPath></defs></svg>
</br>

If the icons are intended for use by Shopify, please provide the following info:

Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
Felipe Scharf (Mercado Pago)

What's the expected date of this change to deploy on Shopify?
30 November

@dannye0231
Copy link
Contributor

Hi @fscharf , are you able to check your SVG? We see a few issues flagged with your submission:

PaymentIconTest#test_Every_payment_SVG_meets_accessibility_requirements [test/unit/payment_icon_test.rb:89]:
{:message=>"The 'clip0_3427_6721' ID should be pi-efecty-clip0_3427_6721 (missing 'pi-' prefix)"}.
Expected /pi-(.*)/ to match "clip0_3427_6721".

@fscharf
Copy link
Author

fscharf commented Dec 2, 2024 •
edited
Loading

Hi @fscharf , are you able to check your SVG? We see a few issues flagged with your submission:

PaymentIconTest#test_Every_payment_SVG_meets_accessibility_requirements [test/unit/payment_icon_test.rb:89]: {:message=>"The 'clip0_3427_6721' ID should be pi-efecty-clip0_3427_6721 (missing 'pi-' prefix)"}. Expected /pi-(.*)/ to match "clip0_3427_6721".

@dannye0231 Fixed.

@fscharf
Copy link
Author

fscharf commented Jan 24, 2025

Any updates on this @Lydia-shan-git @dannye0231 ?
Looking forward to hearing from you.

@dannye0231
Copy link
Contributor

Hi @fscharf can you please re-base this PR?

@fscharf
Copy link
Author

fscharf commented Jan 27, 2025 •
edited
Loading

Hi @fscharf can you please re-base this PR?

@dannye0231 Done.

@dannye0231
Copy link
Contributor

@fscharf I see Efecty listed twice in the YML file (one as other and another one as bank_transfers). Are you able to remove the entry which is not applicable? We can't have two entries with the same names.

@fscharf
Copy link
Author

fscharf commented Jan 27, 2025

@dannye0231 well observed. Fixed.

@dannye0231
Copy link
Contributor

Thanks @fscharf , looks good from my end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lydia-shan-git Lydia-shan-git Awaiting requested review from Lydia-shan-git

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fscharf @dannye0231