-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding payment icon for payment method PayitMonthly #1204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your submission. Please add a 1px stroke via background vector with #000000 and 7% opacity.
# Conflicts: # app/assets/images/payment_icons/payitmonthly.svg
hello, may I ask if this is okay please? Thanks. |
@dannye0231 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure your border colour, width, and radius match the guidelines. They should be black at 7% opacity.
Hi @Lydia-shan-git , Thanks a lot for the review. I am aware the new code has stroke="#000" stroke-opacity=".07" in the rect tag. May I know if that's not the right place to add that? How shall I change it? Thanks again. Also, I am aware that the border requirement is only for if that's possible, we prefer to have no border, like the clear pay icon. Is that allowed and what's the criteria about that? Thanks. |
@dannye0231 Thoughts on their request? Im pretty sure we would prefer having the border for consistency |
Hi, as see the discussion about the border, please allow me to provide some of the examples that have no visible borders. Thanks a lot for the review and taking the feedback as consideration. afterpay.svg |
Hi Danny, May I ask if there are any updates on this? Thanks! |
Hi @mandy6610, it would be best to stick with the border recommendations as this is part of our guidelines. We may have had variations in the past but we are trying to provide more consistency going forward which is why we're asking for the border to be in place. |
Thanks @dannye0231 |
Why are you adding this icons?
I'm adding/updating this icon(s) because we, PayItMonthly, are creating a payment app and this icon is our payment method's icon.
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
What's the expected date of this change to deploy on Shopify?