Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding payment icon for payment method PayitMonthly #1204

Merged
merged 11 commits into from
Jan 8, 2025

Conversation

mandy6610
Copy link
Contributor

Why are you adding this icons?

I'm adding/updating this icon(s) because we, PayItMonthly, are creating a payment app and this icon is our payment method's icon.

Help us identify yourself

  • I'm working/collaborating with the brand directly and they have provided the icons.
  • I'm associated with the brand and I've read all the brand icon’s guidelines.
  • I'm an individual and I've read all the brand icon’s guidelines.

Link to the brand guidelines:

Checklist to add new icons

  • All icons have a corresponding entry in db/payment_icons.yml
  • I have followed the icon guidelines detailed in the CONTRIBUTING.md file
  • I have optimized the icon with SVGO
  • I am confident that all icons are clear and easy to read/understand
  • I have provided a link to the brand icon’s brand guidelines whenever possible.
  • I have attached a screenshot comparison with the example icon provided in guidelines
  • I recognize that if my icon is not approved by the Shopify Partners team it may not receive review nor merger.

If this pull request is not adding new icons, you can remove this checklist.

Attach a screenshot of the icon along side the example Visa icon

pim_icon_vs_example_icon

Tips how to create a screenshot

We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.

<!-- Change background color if needed to showcase your icon better -->
<style> body { background: black; } </style>

<!-- DO NOT DELETE EXAMPLE -->
<svg viewBox="0 0 38 24" xmlns="http://www.w3.org/2000/svg" role="img" width="38" height="24" aria-labelledby="pi-visa"><title id="pi-visa">Visa</title><path opacity=".07" d="M35 0H3C1.3 0 0 1.3 0 3v18c0 1.7 1.4 3 3 3h32c1.7 0 3-1.3 3-3V3c0-1.7-1.4-3-3-3z"/><path fill="#fff" d="M35 1c1.1 0 2 .9 2 2v18c0 1.1-.9 2-2 2H3c-1.1 0-2-.9-2-2V3c0-1.1.9-2 2-2h32"/><path d="M28.3 10.1H28c-.4 1-.7 1.5-1 3h1.9c-.3-1.5-.3-2.2-.6-3zm2.9 5.9h-1.7c-.1 0-.1 0-.2-.1l-.2-.9-.1-.2h-2.4c-.1 0-.2 0-.2.2l-.3.9c0 .1-.1.1-.1.1h-2.1l.2-.5L27 8.7c0-.5.3-.7.8-.7h1.5c.1 0 .2 0 .2.2l1.4 6.5c.1.4.2.7.2 1.1.1.1.1.1.1.2zm-13.4-.3l.4-1.8c.1 0 .2.1.2.1.7.3 1.4.5 2.1.4.2 0 .5-.1.7-.2.5-.2.5-.7.1-1.1-.2-.2-.5-.3-.8-.5-.4-.2-.8-.4-1.1-.7-1.2-1-.8-2.4-.1-3.1.6-.4.9-.8 1.7-.8 1.2 0 2.5 0 3.1.2h.1c-.1.6-.2 1.1-.4 1.7-.5-.2-1-.4-1.5-.4-.3 0-.6 0-.9.1-.2 0-.3.1-.4.2-.2.2-.2.5 0 .7l.5.4c.4.2.8.4 1.1.6.5.3 1 .8 1.1 1.4.2.9-.1 1.7-.9 2.3-.5.4-.7.6-1.4.6-1.4 0-2.5.1-3.4-.2-.1.2-.1.2-.2.1zm-3.5.3c.1-.7.1-.7.2-1 .5-2.2 1-4.5 1.4-6.7.1-.2.1-.3.3-.3H18c-.2 1.2-.4 2.1-.7 3.2-.3 1.5-.6 3-1 4.5 0 .2-.1.2-.3.2M5 8.2c0-.1.2-.2.3-.2h3.4c.5 0 .9.3 1 .8l.9 4.4c0 .1 0 .1.1.2 0-.1.1-.1.1-.1l2.1-5.1c-.1-.1 0-.2.1-.2h2.1c0 .1 0 .1-.1.2l-3.1 7.3c-.1.2-.1.3-.2.4-.1.1-.3 0-.5 0H9.7c-.1 0-.2 0-.2-.2L7.9 9.5c-.2-.2-.5-.5-.9-.6-.6-.3-1.7-.5-1.9-.5L5 8.2z" fill="#142688"/></svg>

<!-- TODO: insert your icon here -->
<YOUR SVG CODE>

<br>
<!-- TODO: insert your icon here -->
<YOUR SVG CODE>
</br

If the icons are intended for use by Shopify, please provide the following info:

Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)

What's the expected date of this change to deploy on Shopify?

Copy link
Collaborator

@nickagin nickagin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission. Please add a 1px stroke via background vector with #000000 and 7% opacity.

mandy6610 and others added 3 commits August 5, 2024 09:20
@mandy6610 mandy6610 requested a review from nickagin August 5, 2024 09:34
@mandy6610
Copy link
Contributor Author

hello, may I ask if this is okay please? Thanks.

@mandy6610
Copy link
Contributor Author

@dannye0231
Hello, seems nickagin] is not active for a while. May I know if you could help trigger the action and check if the icon is alright please? Thanks.

Copy link
Collaborator

@Lydia-shan-git Lydia-shan-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure your border colour, width, and radius match the guidelines. They should be black at 7% opacity.

@mandy6610
Copy link
Contributor Author

mandy6610 commented Nov 4, 2024

Make sure your border colour, width, and radius match the guidelines. They should be black at 7% opacity.

Hi @Lydia-shan-git , Thanks a lot for the review. I am aware the new code has stroke="#000" stroke-opacity=".07" in the rect tag. May I know if that's not the right place to add that? How shall I change it? Thanks again.

Also, I am aware that the border requirement is only for if that's possible, we prefer to have no border, like the clear pay icon. Is that allowed and what's the criteria about that? Thanks.

@Lydia-shan-git
Copy link
Collaborator

@dannye0231 Thoughts on their request? Im pretty sure we would prefer having the border for consistency

@mandy6610
Copy link
Contributor Author

@dannye0231 Thoughts on their request? Im pretty sure we would prefer having the border for consistency

Hi, as see the discussion about the border, please allow me to provide some of the examples that have no visible borders. Thanks a lot for the review and taking the feedback as consideration.

afterpay.svg
clearpay.svg
braintree.svg
clip.svg
collector_bank.svg
danske_bank.svg
dnb.svg
dwolla.svg
elv.svg
esr_paymentslip_switzerland.svg

@mandy6610
Copy link
Contributor Author

@dannye0231

Hi Danny, May I ask if there are any updates on this? Thanks!

@dannye0231
Copy link
Contributor

Hi @mandy6610, it would be best to stick with the border recommendations as this is part of our guidelines. We may have had variations in the past but we are trying to provide more consistency going forward which is why we're asking for the border to be in place.

@mandy6610
Copy link
Contributor Author

Thanks @dannye0231
I can understand that and I have added border to our icon. Thanks again.

@dannye0231 dannye0231 merged commit c97cd7b into activemerchant:master Jan 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants