Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate beacons analysis to using full timestamp list #745

Merged
merged 12 commits into from
Aug 19, 2022

Conversation

lisaSW
Copy link
Contributor

@lisaSW lisaSW commented Aug 18, 2022

Beacons analysis was using a unique set of timestamps for its analysis. This PR migrates it to using the full timestamp list for each section of analysis and scoring.

@lisaSW lisaSW requested a review from Zalgo2462 August 18, 2022 17:20
@lisaSW lisaSW force-pushed the beacons-to-tsfull branch from 08e5d03 to 7585ba0 Compare August 18, 2022 17:26
Copy link
Contributor

@Zalgo2462 Zalgo2462 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to cap an edge case where the dispersion score could go negative. Looks good otherwise.

pkg/beacon/analyzer.go Show resolved Hide resolved
Copy link
Contributor

@Zalgo2462 Zalgo2462 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zalgo2462 Zalgo2462 merged commit ea1007d into master Aug 19, 2022
@Zalgo2462 Zalgo2462 deleted the beacons-to-tsfull branch August 19, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants