Updated Beacon Scoring #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Zalgo2462
suggested changes
Jul 19, 2022
There was a problem hiding this comment.
In this first review, I'm just looking over the code and documentation.
Everything looks solid 🎉. I'm really excited to see the new results.
Once we go through this first round of changes, we'll want to copy the changes into the other beaconing packages.
I have a few small change requests:
Bug fix changes:
- Add 1 to
totalin thecreateBucketsfunction to fix an off-by-one error where we end up with one less bucket than we'd like
Code maintenance changes:
- Move the rounding code into its own function in the
utilpackage - Split the
freqCountcalculation out ofcreateHistogramand into its own function - Avoid calculating
totalincreateHistogramby callinglen(tsList)
Documentation Changes:
- Add documentation to
getTsHistogramScore - Change/ remove the comment in
getTsHistogramScorewhich references a 24 hour observation period - Add comments to
freqListandfreqCount
Personal request:
- Add
Top Intvlback into the show-beacons and report-beacons code
| } | ||
| } | ||
|
|
||
| freqMean := float64(total) / float64(len(freqList)) |
There was a problem hiding this comment.
I believe we can avoid calculating total by calling len(tsList).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to beacon scoring metrics per testing against simulated c2 data and gathered false positives.
Closes #736