Add unique indexes to beaconFQDN and beaconProxy collections
#689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fullmetalcache
requested changes
Aug 17, 2021
pkg/beaconproxy/mongodb.go
Outdated
| @@ -47,6 +47,7 @@ func (r *repo) CreateIndexes() error { | |||
| // set desired indexes | |||
| indexes := []mgo.Index{ | |||
| {Key: []string{"-score"}}, | |||
| {Key: []string{"src", "dst", "fqdn", "src_network_uuid", "dst_network_uuid"}, Unique: true}, | |||
There was a problem hiding this comment.
In #690 , we are changing the keying to be src-fqdn and cutting out the dst (i.e., proxy) as part of the keying since it isn't really relevant for analysis. Can we please cut dst and dst_network_uuid from this key and just have it be "src" and "fqdn"?
There was a problem hiding this comment.
Let's revert the beaconProxy index commit from this PR and apply the change only in #690.
Zalgo2462
force-pushed
the
688-add-fqdn-proxy-indexes
branch
from
4df2555 to
0489691
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #688
Adds the necessary unique indexes to cover the upserts performed in the fqdn and proxy beacon analyses.
Running a
.explainfor the FQDN beacon selector (see #688) now returns the following plan without a filter stage: