Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against Ruby 3.4 #647

Merged
merged 1 commit into from
Dec 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ jobs:
- "3.1"
- "3.2"
- "3.3"
- "3.4"
rails:
- rails_70
- rails_71
Expand All @@ -25,6 +26,8 @@ jobs:
exclude:
- ruby: "3.1"
rails: rails_80
- ruby: "3.4"
rails: rails_70
steps:
- uses: actions/checkout@v4
- name: Configure bundler (default)
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
pull_request:

env:
RUBY_VERSION: ${{ vars.RUBOCOP_RUBY_VERSION || '3.3' }}
RUBY_VERSION: ${{ vars.RUBOCOP_RUBY_VERSION || '3.4' }}

jobs:
rubocop:
Expand Down Expand Up @@ -36,7 +36,7 @@
- uses: reviewdog/action-rubocop@v2
if: steps.changed-files.outputs.any_changed == 'true'
with:
fail_level: any

Check failure on line 39 in .github/workflows/rubocop.yml

View workflow job for this annotation

GitHub Actions / actionlint

[actionlint] .github/workflows/rubocop.yml#L39

input "fail_level" is not defined in action "reviewdog/action-rubocop@v2". available inputs are "fail_on_error", "filter_mode", "github_token", "level", "only_changed", "reporter", "reviewdog_flags", "rubocop_extensions", "rubocop_flags", "rubocop_version", "skip_install", "tool_name", "use_bundler", "workdir" [action]
Raw output
.github/workflows/rubocop.yml:39:11: input "fail_level" is not defined in action "reviewdog/action-rubocop@v2". available inputs are "fail_on_error", "filter_mode", "github_token", "level", "only_changed", "reporter", "reviewdog_flags", "rubocop_extensions", "rubocop_flags", "rubocop_version", "skip_install", "tool_name", "use_bundler", "workdir" [action]
filter_mode: nofilter # added (default), diff_context, file, nofilter
github_token: ${{ secrets.GITHUB_TOKEN }}
skip_install: true
Expand Down
41 changes: 20 additions & 21 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ GEM
ast (2.4.2)
base64 (0.2.0)
benchmark (0.4.0)
bigdecimal (3.1.8)
bigdecimal (3.1.9)
builder (3.3.0)
capybara (3.40.0)
addressable
Expand All @@ -106,18 +106,18 @@ GEM
diff-lcs (1.5.1)
docile (1.4.1)
drb (2.2.1)
erubi (1.13.0)
erubi (1.13.1)
globalid (1.2.1)
activesupport (>= 6.1)
i18n (1.14.6)
concurrent-ruby (~> 1.0)
io-console (0.8.0)
irb (1.14.2)
irb (1.14.3)
rdoc (>= 4.0.0)
reline (>= 0.4.2)
json (2.9.0)
json (2.9.1)
language_server-protocol (3.17.0.3)
logger (1.6.3)
logger (1.6.4)
loofah (2.23.1)
crass (~> 1.0.2)
nokogiri (>= 1.12.0)
Expand All @@ -132,43 +132,42 @@ GEM
mini_mime (1.1.5)
mini_portile2 (2.8.8)
minitest (5.25.4)
net-imap (0.5.1)
net-imap (0.5.4)
date
net-protocol
net-pop (0.1.2)
net-protocol
net-protocol (0.2.2)
timeout
net-smtp (0.5.0)
net-protocol
nio4r (2.7.4)
nokogiri (1.17.2)
nokogiri (1.18.0)
mini_portile2 (~> 2.8.2)
racc (~> 1.4)
nokogiri (1.17.2-aarch64-linux)
nokogiri (1.18.0-aarch64-linux-gnu)
racc (~> 1.4)
nokogiri (1.17.2-arm64-darwin)
nokogiri (1.18.0-arm64-darwin)
racc (~> 1.4)
nokogiri (1.17.2-x86_64-darwin)
nokogiri (1.18.0-x86_64-darwin)
racc (~> 1.4)
nokogiri (1.17.2-x86_64-linux)
nokogiri (1.18.0-x86_64-linux-gnu)
racc (~> 1.4)
parallel (1.26.3)
parser (3.3.6.0)
ast (~> 2.4.1)
racc
pry (0.15.0)
pry (0.15.2)
coderay (~> 1.1)
method_source (~> 1.0)
psych (5.2.1)
psych (5.2.2)
date
stringio
public_suffix (6.0.1)
racc (1.8.1)
rack (3.1.8)
rack-session (2.0.0)
rack (>= 3.0.0)
rack-test (2.1.0)
rack-test (2.2.0)
rack (>= 1.3)
rackup (2.2.1)
rack (>= 3)
Expand Down Expand Up @@ -203,10 +202,10 @@ GEM
zeitwerk (~> 2.6)
rainbow (3.1.1)
rake (13.2.1)
rdoc (6.9.0)
rdoc (6.10.0)
psych (>= 4.0.0)
regexp_parser (2.9.3)
reline (0.5.12)
regexp_parser (2.10.0)
reline (0.6.0)
io-console (~> 0.5)
rexml (3.4.0)
rspec (3.13.0)
Expand Down Expand Up @@ -252,7 +251,7 @@ GEM
rubocop-rspec (3.3.0)
rubocop (~> 1.61)
ruby-progressbar (1.13.0)
securerandom (0.4.0)
securerandom (0.4.1)
simplecov (0.22.0)
docile (~> 1.1)
simplecov-html (~> 0.11)
Expand All @@ -264,7 +263,7 @@ GEM
simplecov_json_formatter (0.1.4)
stringio (3.1.2)
thor (1.3.2)
timeout (0.4.2)
timeout (0.4.3)
tzinfo (2.0.6)
concurrent-ruby (~> 1.0)
unicode-display_width (3.1.2)
Expand Down Expand Up @@ -304,4 +303,4 @@ DEPENDENCIES
simplecov-cobertura

BUNDLED WITH
2.5.23
2.6.2
25 changes: 12 additions & 13 deletions gemfiles/rails_70/Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ GEM
date (3.4.1)
diff-lcs (1.5.1)
docile (1.4.1)
erubi (1.13.0)
erubi (1.13.1)
globalid (1.2.1)
activesupport (>= 6.1)
i18n (1.14.6)
Expand All @@ -113,34 +113,33 @@ GEM
mini_mime (1.1.5)
mini_portile2 (2.8.8)
minitest (5.25.4)
net-imap (0.5.1)
net-imap (0.5.4)
date
net-protocol
net-pop (0.1.2)
net-protocol
net-protocol (0.2.2)
timeout
net-smtp (0.5.0)
net-protocol
nio4r (2.7.4)
nokogiri (1.17.2)
nokogiri (1.18.0)
mini_portile2 (~> 2.8.2)
racc (~> 1.4)
nokogiri (1.17.2-aarch64-linux)
nokogiri (1.18.0-aarch64-linux-gnu)
racc (~> 1.4)
nokogiri (1.17.2-arm64-darwin)
nokogiri (1.18.0-arm64-darwin)
racc (~> 1.4)
nokogiri (1.17.2-x86_64-darwin)
nokogiri (1.18.0-x86_64-darwin)
racc (~> 1.4)
nokogiri (1.17.2-x86_64-linux)
nokogiri (1.18.0-x86_64-linux-gnu)
racc (~> 1.4)
pry (0.15.0)
pry (0.15.2)
coderay (~> 1.1)
method_source (~> 1.0)
public_suffix (6.0.1)
racc (1.8.1)
rack (2.2.10)
rack-test (2.1.0)
rack-test (2.2.0)
rack (>= 1.3)
rails (7.0.8.7)
actioncable (= 7.0.8.7)
Expand Down Expand Up @@ -171,7 +170,7 @@ GEM
thor (~> 1.0)
zeitwerk (~> 2.5)
rake (13.2.1)
regexp_parser (2.9.3)
regexp_parser (2.10.0)
rexml (3.4.0)
rspec (3.13.0)
rspec-core (~> 3.13.0)
Expand Down Expand Up @@ -204,7 +203,7 @@ GEM
simplecov-html (0.13.1)
simplecov_json_formatter (0.1.4)
thor (1.3.2)
timeout (0.4.2)
timeout (0.4.3)
tzinfo (2.0.6)
concurrent-ruby (~> 1.0)
websocket-driver (0.7.6)
Expand Down Expand Up @@ -235,4 +234,4 @@ DEPENDENCIES
zeitwerk (~> 2.6.18)

BUNDLED WITH
2.5.23
2.6.2
39 changes: 19 additions & 20 deletions gemfiles/rails_71/Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ GEM
public_suffix (>= 2.0.2, < 7.0)
base64 (0.2.0)
benchmark (0.4.0)
bigdecimal (3.1.8)
bigdecimal (3.1.9)
builder (3.3.0)
capybara (3.40.0)
addressable
Expand All @@ -111,16 +111,16 @@ GEM
diff-lcs (1.5.1)
docile (1.4.1)
drb (2.2.1)
erubi (1.13.0)
erubi (1.13.1)
globalid (1.2.1)
activesupport (>= 6.1)
i18n (1.14.6)
concurrent-ruby (~> 1.0)
io-console (0.8.0)
irb (1.14.2)
irb (1.14.3)
rdoc (>= 4.0.0)
reline (>= 0.4.2)
logger (1.6.3)
logger (1.6.4)
loofah (2.23.1)
crass (~> 1.0.2)
nokogiri (>= 1.12.0)
Expand All @@ -136,39 +136,38 @@ GEM
mini_portile2 (2.8.8)
minitest (5.25.4)
mutex_m (0.3.0)
net-imap (0.5.1)
net-imap (0.5.4)
date
net-protocol
net-pop (0.1.2)
net-protocol
net-protocol (0.2.2)
timeout
net-smtp (0.5.0)
net-protocol
nio4r (2.7.4)
nokogiri (1.17.2)
nokogiri (1.18.0)
mini_portile2 (~> 2.8.2)
racc (~> 1.4)
nokogiri (1.17.2-aarch64-linux)
nokogiri (1.18.0-aarch64-linux-gnu)
racc (~> 1.4)
nokogiri (1.17.2-arm64-darwin)
nokogiri (1.18.0-arm64-darwin)
racc (~> 1.4)
nokogiri (1.17.2-x86_64-darwin)
nokogiri (1.18.0-x86_64-darwin)
racc (~> 1.4)
nokogiri (1.17.2-x86_64-linux)
nokogiri (1.18.0-x86_64-linux-gnu)
racc (~> 1.4)
pry (0.15.0)
pry (0.15.2)
coderay (~> 1.1)
method_source (~> 1.0)
psych (5.2.1)
psych (5.2.2)
date
stringio
public_suffix (6.0.1)
racc (1.8.1)
rack (3.1.8)
rack-session (2.0.0)
rack (>= 3.0.0)
rack-test (2.1.0)
rack-test (2.2.0)
rack (>= 1.3)
rackup (2.2.1)
rack (>= 3)
Expand Down Expand Up @@ -202,10 +201,10 @@ GEM
thor (~> 1.0, >= 1.2.2)
zeitwerk (~> 2.6)
rake (13.2.1)
rdoc (6.9.0)
rdoc (6.10.0)
psych (>= 4.0.0)
regexp_parser (2.9.3)
reline (0.5.12)
regexp_parser (2.10.0)
reline (0.6.0)
io-console (~> 0.5)
rexml (3.4.0)
rspec (3.13.0)
Expand All @@ -229,7 +228,7 @@ GEM
rspec-mocks (~> 3.13)
rspec-support (~> 3.13)
rspec-support (3.13.2)
securerandom (0.4.0)
securerandom (0.4.1)
simplecov (0.22.0)
docile (~> 1.1)
simplecov-html (~> 0.11)
Expand All @@ -241,7 +240,7 @@ GEM
simplecov_json_formatter (0.1.4)
stringio (3.1.2)
thor (1.3.2)
timeout (0.4.2)
timeout (0.4.3)
tzinfo (2.0.6)
concurrent-ruby (~> 1.0)
websocket-driver (0.7.6)
Expand Down Expand Up @@ -272,4 +271,4 @@ DEPENDENCIES
zeitwerk (~> 2.6.18)

BUNDLED WITH
2.5.23
2.6.2
Loading
Loading